8000 Add custom installation directory support by lmontanares · Pull Request #4 · NomenAK/SuperClaude · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add custom installation directory support #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

Add custom installation directory support #4

merged 1 commit into from
Jun 24, 2025

Conversation

lmontanares
Copy link
Contributor

Summary

  • Add --dir argument for custom installation path with validation
  • Add confirmation prompt showing target directory before installation
  • Add comprehensive help text with usage examples
  • Fix backup logic to only prompt when directory contains files
  • Update README.md with installation options and examples

Features Added

  • Custom Directory Support: Install to any location via --dir flag
  • Smart Backup: Only prompts for backup when files exist, shows info message for empty directories
  • Path Handling: Converts relative paths to absolute, validates directory structure
  • Help System: Complete --help documentation with examples
  • Backward Compatibility: Default behavior unchanged (~/.claude/)

Usage Examples

./install.sh                           # Default: ~/.claude/
./install.sh --dir /opt/claude          # Custom location
./install.sh --dir ./project-claude    # Project-specific
./install.sh --help                    # Show help

🤖 Generated with Claude Code

@lmontanares @claude
Add custom installation directory support
df946b1 
- Add --dir argument for custom installation path
- Add confirmation prompt showing target directory
- Add help text with usage examples and --help flag
- Update all file operations to use custom directory
- Convert relative paths to absolute paths
- Fix backup prompt to only show when directory has files
- Add informational message for empty directories
- Update README.md with installation options and examples
- Maintain backward compatibility with default ~/.claude

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@NomenAK
Copy link
Owner
NomenAK commented Jun 24, 2025

Testing Complete ✅

I've thoroughly tested PR #4 and made minor improvements:

Testing Results:

  • ✅ Default installation behavior works correctly
  • ✅ Custom directory installation (relative & absolute paths)
  • ✅ Backup functionality creates proper timestamped backups
  • ✅ Help text displays correctly
  • ✅ Installation cancellation works as expected

Improvements Added:

  1. Added permission note in help text for system directories
  2. Updated README.md example to mention sudo requirement
  3. Improved variable quoting in directory check for better shell compatibility

Recommendation: Ready to merge 🚀

The implementation is solid, maintains backward compatibility, and adds valuable functionality for project-specific installations.

@NomenAK NomenAK merged commit 0ff7401 into NomenAK:master Jun 24, 2025
@NomenAK
Copy link
Owner
NomenAK commented Jun 24, 2025

Thank for your contribution !

@lmontanares lmontanares deleted the feature/custom-install-directory branch June 24, 2025 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5544
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmontanares @NomenAK
0