8000 Faith Salute Solaris Edition: Now with 100% More Sound, 0% Icon by RiririFRin · Pull Request #71 · NovaSector/Solaris · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Faith Salute Solaris Edition: Now with 100% More Sound, 0% Icon #71

New iss 8000 ue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 23, 2025
Merged

Faith Salute Solaris Edition: Now with 100% More Sound, 0% Icon #71

merged 4 commits into from
May 23, 2025

Conversation

RiririFRin
Copy link
Contributor

About The Pull Request

  • Implements the Faith Salute emote system.
  • Emits a sound effect when a player performs a salute, audible to others of the same faith.
  • Currently, icon animation is not included — the icon line is commented out until art assets are available.
  • Includes basic groundwork for future visual effects (e.g., unique faith/patron symbols).
  • Leaves room for future enhancements like priest-specific icons or animations.

Testing Evidence

  • Tested in-game: emote triggers correctly, sound plays for players of the same faith.
  • No errors or unexpected behavior observed.

Why It's Good For The Game

  • Enhances roleplay and immersion for CLEEEERGY characters.
  • Encourages faction/faith identity by allowing exclusive audio cues.
  • Prepares visual framework for future divine iconography and priesthood differentiation without blocking current functionality.

@RiririFRin RiririFRin requested a review from unit0016 as a code owner May 23, 2025 19:16
@RiririFRin
Copy link
Contributor Author

Currently

		var/icon_plane = WEATHER_EFFECT_PLANE	//Will show up through the cone.

Is showing as code\modules\mob\living\overhead_effects.dm:38:warning (unused_var): icon_plane: variable defined but not used

Because icon is being commented out, but it should be okay-???

@unit0016
Copy link
Contributor

I don't particularly like the secret society motif but there were loreteam groundworks planned that would ideally use this, so I'm pulling the trigger.

@unit0016 unit0016 merged commit d40968f into NovaSector:main May 23, 2025
4 of 5 checks passed
@RiririFRin
Copy link
Contributor Author

@unit1006 Can fix / can do, I wanted to make it show differently by ranks of devotion (and the crown which has same level as clergy, because the crown was coronate by the church) but that can come later! Code is pretty easy to modify too.

@RiririFRin
Copy link
Contributor Author

Due to lack of logo its confirmed not working, I will fix this PR soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@unit0016 unit0016 Awaiting requested review from unit0016 unit0016 is a code owner

Assignees
No one assigned
Labels
Code Sprite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RiririFRin @unit0016
0