8000
Add double-precision support for Avian by Noxmore · Pull Request #110 · Noxmore/bevy_trenchbroom · GitHub
More Web Proxy on the site http://driver.im/
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does what it says on the tin, this was originally implemented by #109, but this implementation doesn't split f32 and f64 into their own features.
It looks like bevy_rapier3d doesn't even support double-precision, even if rapier3d does via rapier3d-f64, so this support doesn't extend to Rapier for now.
Hmm, thanks for taking this on, but it looks like this permanently enables f64 for Avian (which is not the default for typical usage). My use case which spurred the PR was a prototype where I'm using f64 for silly reasons that I'm likely to drop. That's why my PR allowed the client to make that decision by enabling either the bevy_trenchbroom/avian32 or bevy_trenchbroom/avian64 features.
It does for BTB testing with dev-dependencies and the physics example, but that shouldn't affect you. Are you seeing this in cargo tree?
You are right, there's no problem here. I got confused by the diff and didn't realize it was only the dev-dependencies version with that feature change. I can indeed build example/physics with f32 just fine. (Sorry for making noise. I'm only two years into Rust and still learning things! :)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Does what it says on the tin, this was originally implemented by #109, but this implementation doesn't split
f32andf64into their own features.It looks like bevy_rapier3d doesn't even support double-precision, even if rapier3d does via rapier3d-f64, so this support doesn't extend to Rapier for now.
Closes #109