Add global transform* application #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds convenience and removes a potential foot gun, especially with the removal of
#[require(...)]adding base classes. This has the cost of a little logic fragmenting.The main reason i'm good with this is because position and rotation properties are also hardcoded on every entity in TrenchBroom if you use their associated tools, meaning this change makes the crate align more with what's seen in-editor by default.
*The exception to this is
scale, which isn't hardcoded at all, completely user-defined, which is why scale isn't currently applied with the global applicator. If we make a scale property a more structured thing in the config in the future, this could very well change.