10000 [18.0][MIG] hr_timesheet_editable_top: Migration to 18.0 by innovara · Pull Request #753 · OCA/timesheet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[18.0][MIG] hr_timesheet_editable_top: Migration to 18.0 #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 11, 2025
Merged

[18.0][MIG] hr_timesheet_editable_top: Migration to 18.0 #753

merged 5 commits into from
May 11, 2025

Conversation

innovara
Copy link

Migration of hr_timesheet_editable_top to 18.0.

The attribute is no longer tree but list.

@innovara innovara force-pushed the 18.0-port-hr_timesheet_editable_top branch from b0b9d18 to d3e6f5a Compare March 15, 2025 11:24
@innovara
Copy link
Author
innovara commented Apr 8, 2025

@miquelalzanillas @lbarry-apsl @BernatObrador @peluko00 @javierobcn @ppyczko @mpascuall

Would you kindly review this PR for me please? Same as my previous request. I of course would be very happy to review any of your PRs.

mpascuall
mpascuall approved these changes Apr 14, 2025
View reviewed changes
Copy link
@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@innovara innovara force-pushed the 18.0-port-hr_timesheet_editable_top branch from d3e6f5a to 88ebf2e Compare April 14, 2025 12:49
@innovara
Copy link
Author

Since the migration to 17.0 of this add on has been merged already, I have updated this PR using 17.0 as the source of the migration instead of 16.0 as it was originally.

@innovara innovara force-pushed the 18.0-port-hr_timesheet_editable_top branch from 88ebf2e to 66ba291 Compare April 15, 2025 14:01
@innovara innovara mentioned this pull request Apr 16, 2025
Open
10 tasks
BhaveshHeliconia
BhaveshHeliconia approved these changes Apr 16, 2025
View reviewed changes
Copy link
@BhaveshHeliconia BhaveshHeliconia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Tests Ok.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

ivs-cetmix
ivs-cetmix requested changes May 10, 2025
View reviewed changes
Copy link
Member
@ivs-cetmix ivs-cetmix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @innovara, thank you for your contribution! Please check the migration wiki once again and squash the administrative commits.
image

@innovara innovara force-pushed the 18.0-port-hr_timesheet_editable_top branch from 66ba291 to ebc345c Compare May 11, 2025 10:00
@innovara innovara requested a review from ivs-cetmix May 11, 2025 10:03
@innovara
Copy link
Author

@ivs-cetmix please check. I followed https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-bots-or-weblate

ivs-cetmix
ivs-cetmix approved these changes May 11, 2025
View reviewed changes
Copy link
Member
@ivs-cetmix ivs-cetmix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@innovara, much better now 😄
Thank you for your contribution!

@ivs-cetmix
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-753-by-ivs-cetmix-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a0b7ded into OCA:18.0 May 11, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at cc86009. Thanks a lot for contributing to OCA. ❤️

@innovara innovara deleted the 18.0-port-hr_timesheet_editable_top branch May 11, 2025 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivs-cetmix ivs-cetmix ivs-cetmix approved these changes

@mpascuall mpascuall mpascuall approved these changes

@BhaveshHeliconia BhaveshHeliconia BhaveshHeliconia approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@innovara @OCA-git-bot @ivs-cetmix @mpascuall @BhaveshHeliconia @victor-champonnois @mymage
0