8000 [17.0][ADD] hr_timesheet_autofill_project_off by innovara · Pull Request #755 · OCA/timesheet · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[17.0][ADD] hr_timesheet_autofill_project_off #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

innovara
Copy link

This module disables the project field being automatically filled when a new line is added to a timesheet.

Details about the feature that this module disables on odoo/odoo@ad1b64a and a relevant fix on odoo/odoo@623ecff

According to the description of the so-called improvement, if the last five timesheets belong to the same project then that project is considered a favorite project.

Why five is anybody's guess but the real problem with this is that it induces errors. Inevitably the user will fail to change the project when the automatic selection is incorrect, and book time to another project. If the mistake is not picked before billing then the risk is that the client will do so and then good luck explaining why you are charging them for work done for others.

While the feature might work well for those working on one project at a time, a good number of professional services' users billing on hourly rates juggle between many assignments concurrently so the project that is filled automatically will often be incorrect thus not saving them time while adding the risk explained above.

@innovara innovara force-pushed the hr_timesheet_autofill_project_off branch from 33e29f1 to 0a39de3 Compare March 20, 2025 22:25
@innovara
Copy link
Author
innovara commented Apr 8, 2025

@miquelalzanillas @lbarry-apsl @BernatObrador @peluko00 @javierobcn @ppyczko @mpascuall

Would you kindly review this PR for me please? Same as my previous request. I of course would be very happy to review any of your PRs.

Copy link
Member
@lbarry-apsl lbarry-apsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code revised, LGTM!

Copy link
@peluko00 peluko00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
@mpascuall mpascuall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@innovara innovara force-pushed the hr_timesheet_autofill_project_off branch from 0a39de3 to 1aa84c9 Compare April 15, 2025 14:04
This module disables the project field being automatically filled when a new line is added to a timesheet.

Details about the feature that this module disables on odoo/odoo@ad1b64a

Signed-off-by: Manuel Fombuena <mfombuena@innovara.tech>
@innovara innovara force-pushed the hr_timesheet_autofill_project_off branch from 1aa84c9 to d012641 Compare April 15, 2025 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0