[15.0][FIX] web_m2x_options M2ODialog not fully functional #2304
Conversation
There was a problem hiding this comment.
The Code is working and looks good.
I am not sure if it is really useful to also remove the "Create and Edit" button in the popup with the same configuration keys.
We removed the "Create..." from the dropdown because it was used accidently to many times, but using the button would be ok for us.
I did another fix #2318 addressing another issue, which will have some conflict on the _search changes.
Shall we add another config key for the popup and merge both PR before merging it into 15.0?
Happy for it to be another option, but the client who raised this correctly pointed out that if you're banning create on the dropdown then it almost certainly makes no sense to be in the popup, because you'll still end up with a badly configured product :) However, I do understand that not everyone will have this opinion, so I'm happy to make it a separate option, if that's what people want? :)
Makes sense, but I'm not sure if I have the time to do this for at least a few days (probably longer). Do you have time to try and pull these changes into yours, and I close this PR? What works for you? :) |
…stream removal of search_create_popup custom_event, M2ODialog offers both Create and Create and Edit, even if the options are diabled
52bde74 to
8f14788
Compare
|
Closing as superseded by #2901 |
Prior to this patch:
search_create_popupcustom_event (odoo/odoo@1d4d2a6). The Create and Edit button just does "nothing".