Prevent domain field evaluation from failing when: (1) the domain is … #2316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…given by a related field and (2) the path to the target field is not yet traversable. In this cases, reading the field from javascript code will yield false. This fix makes the frontend assume a "[]" domain whenever the field refered to in domain="" attribute contains a false value.
|
Hey @joao-jeronimo, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
ivantodorovich
approved these changes
Nov 3, 2022
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have some code like this:
# In Python: class AccountPaymentOrder(models.Model): _inherit = "account.payment.order" json_allowed_journals_domain = fields.Char(related="payment_mode_id.json_allowed_journals_domain")<!-- In XML: --> <xpath expr="//field[@name='journal_id']" position="attributes"> <attribute name="domain">json_allowed_journals_domain</attribute> </xpath>And form loading was failing when creating a new record, because the field payment_mode_id was not yet set.
This pull request fixes this:
Prevent domain field evaluation from failing when: (1) the domain is given
by a related field and (2) the path to the target field is not yet
traversable. In this cases, reading the field from javascript code will
yield false. This fix makes the frontend assume a "[]" domain whenever the
field refered to in domain="" attribute contains a false value.