[14.0][FIX] web_ir_action_act_*: add/fix access rights #2466

aleuffre · 2023-03-23T11:10:34Z

Squashes the warning

odoo.modules.loading: The model ir.actions.act_view_reload has no access rules, consider adding one. E.g. access_ir_actions_act_view_reload,access_ir_actions_act_view_reload,model_ir_actions_act_view_reload,base.group_user,1,0,0,0

tarteo · 2023-03-24T12:14:38Z

web_ir_actions_act_view_reload/security/ir.model.access.csv

@@ -0,0 +1,2 @@
+id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
+crud_ir_actions_act_view_reload,
8000
access_ir_actions_act_wiew_reload,model_ir_actions_act_view_reload,,1,1,1,1


Does the user need write, delete and create rights?

I copied https://github.com/OCA/web/blob/14.0/web_ir_actions_act_multi/security/ir.model.access.csv
and https://github.com/OCA/web/blob/14.0/web_ir_actions_act_window_message/security/ir.model.access.csv

Happy to change it, and was a bit weird to me as well, but I assumed these were like that for a reason.

I agree with tarteo... look at Odoo: https://github.com/odoo/odoo/blob/14.0/odoo/addons/base/security/ir.model.access.csv#L85

@Tardo, you agreed with @tarteo but your link shows full CRUD rights like this PR, is there a typo in your comment ?

Yeah, the main difference is the group :) ... No Group = All users can do the operations.

@Tardo, aaaah I missed that

so, do you want me to add the group like in base Odoo? Maybe on all three modules?

Edit: done

Yes, i think that this change should be made on all modules. Thanks!

Add or fix access rights for actions, like in base Odoo

Tardo

LGTM, thanks!

OCA-git-bot · 2023-03-31T18:00:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

aleuffre · 2023-06-30T14:04:43Z

@OCA/web-maintainers

hbrunn · 2023-07-01T12:12:53Z

/ocabot merge patch

OCA-git-bot · 2023-07-01T12:13:52Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-2466-by-hbrunn-bump-patch, awaiting test results.

OCA-git-bot · 2023-07-01T12:17:20Z

@hbrunn The merge process could not be finalized, because command git push origin 14.0-ocabot-merge-pr-2466-by-hbrunn-bump-patch:14.0 failed with output:

To https://github.com/OCA/web
 ! [rejected]          14.0-ocabot-merge-pr-2466-by-hbrunn-bump-patch -> 14.0 (fetch first)
error: failed to push some refs to 'https://***@github.com/OCA/web'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

OCA-git-bot · 2023-07-01T12:17:35Z

Congratulations, your PR was merged at 1e67c14. Thanks a lot for contributing to OCA. ❤️

tarteo reviewed Mar 24, 2023

View reviewed changes

ypapouin approved these changes Mar 31, 2023

View reviewed changes

[14.0][FIX] web_ir_action_act_*: add/fix access rights

f40dd6f

Add or fix access rights for actions, like in base Odoo

aleuffre force-pushed the 14.0-act_view_reload_security branch from f3c6da9 to f40dd6f Compare March 31, 2023 15:40

aleuffre changed the title ~~[14.0][FIX] web_ir_action_act_view_re 8000 load: add access rights~~ [14.0][FIX] web_ir_action_act_*: add/fix access rights Mar 31, 2023

Tardo approved these changes Mar 31, 2023

View reviewed changes

OCA-git-bot added approved ready to merge labels Mar 31, 2023

hbrunn approved these changes Jul 1, 2023

View reviewed changes

OCA-git-bot added the bot is merging ⏳ label Jul 1, 2023

OCA-git-bot removed the bot is merging ⏳ label Jul 1, 2023

OCA-git-bot merged commit b36fd5f into OCA:14.0 Jul 1, 2023

OCA-git-bot added the merged 🎉 label Jul 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[14.0][FIX] web_ir_action_act_*: add/fix access rights #2466

[14.0][FIX] web_ir_action_act_*: add/fix access rights #2466

		@@ -0,0 +1,2 @@
		id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
		crud_ir_actions_act_view_reload, 8000 access_ir_actions_act_wiew_reload,model_ir_actions_act_view_reload,,1,1,1,1

[14.0][FIX] web_ir_action_act_*: add/fix access rights #2466

[14.0][FIX] web_ir_action_act_*: add/fix access rights #2466

Conversation

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment