8000 [14.0][FIX] web_widget_domain_editor_dialog: keep context by chienandalu · Pull Request #2642 · OCA/web · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
8000

[14.0][FIX] web_widget_domain_editor_dialog: keep context #2642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2023
Merged

[14.0][FIX] web_widget_domain_editor_dialog: keep context #2642

merged 1 commit into from
Oct 18, 2023

Conversation

chienandalu
Copy link
Member

fw of #2641

The dialog needs to keep the context so translations and other things work as expected.

cc @Tecnativa TT45543

please review @CarlosRoca13 @pedrobaeza

[FIX] web_widget_domain_editor_dialog: keep context
8173c33 
The dialog needs to keep the context so translations and other things
work as expected.

TT45543
@pedrobaeza pedrobaeza added this to the 14.0 milestone Oct 18, 2023
pedrobaeza
pedrobaeza approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member
@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fast-tracking as already merged in 15.0 and the patch is the same:

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-2642-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 121d954 into OCA:14.0 Oct 18, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at c11eef7. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 14.0-fix-web_widget_domain_editor_dialog-ctx branch October 18, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@chienandalu @OCA-git-bot @pedrobaeza
0