8000 [17.0][MIG] web_search_with_and by JasminSForgeFlow · Pull Request #3090 · OCA/web · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[17.0][MIG] web_search_with_and #3090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Mar 19, 2025

Conversation

JasminSForgeFlow
Copy link
Contributor

Standard Migration

@ForgeFlow

Andrius Preimantas and others added 29 commits February 12, 2025 11:19
Add README.rst

Too short underline for module title in README.rst

Improving module meta information

Version 1.0

W391 blank line at end of file

Remove module description because README.rst is there

web_search_with_and: Latest OCA conventions
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: web-16.0/web-16.0-web_search_with_and
Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_search_with_and/
@JasminSForgeFlow JasminSForgeFlow marked this pull request as ready for review February 12, 2025 08:38
Copy link
Contributor
@JordiMForgeFlow JordiMForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code + functional review

Copy link
@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review. It works.

Copy link
@Jortolsa-S73 Jortolsa-S73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review

@LoisRForgeFlow
Copy link
Contributor

This PR is superseding #2876. I hope it now include a fix for the concerns @StefanRijnhart had there. @StefanRijnhart would you mind taking a look?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@JasminSForgeFlow JasminSForgeFlow force-pushed the 17.0-mig-web_search_with_and branch from 3f7d22d to d4f38ca Compare February 17, 2025 10:51
@LoisRForgeFlow
Copy link
Contributor

@OCA/web-maintainers ready to merge I think

@etobella
Copy link
Member

@StefanRijnhart as you blocked the previous PR, can I kindly ask for your review?

Copy link
Member
@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my concerns on the original PR!

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-3090-by-StefanRijnhart-bump-nobump, awaiting test results.

@StefanRijnhart
Copy link
Member

/ocabot migration web_search_with_and

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Mar 19, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request Mar 19, 2025
32 tasks
@OCA-git-bot OCA-git-bot merged commit 5f74fbf into OCA:17.0 Mar 19, 2025
11 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d7b0f0a. Thanks a lot for contributing to OCA. ❤️

@MiquelRForgeFlow MiquelRForgeFlow deleted the 17.0-mig-web_search_with_and branch March 19, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0