-
-
Notifications
You must be signed in to change notification settings - Fork 2k
[17.0][MIG] web_search_with_and #3090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] web_search_with_and #3090
Conversation
Add README.rst Too short underline for module title in README.rst Improving module meta information Version 1.0 W391 blank line at end of file Remove module description because README.rst is there web_search_with_and: Latest OCA conventions
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-16.0/web-16.0-web_search_with_and Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_search_with_and/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code + functional review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review. It works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review
This PR is superseding #2876. I hope it now include a fix for the concerns @StefanRijnhart had there. @StefanRijnhart would you mind taking a look? |
This PR has the |
3f7d22d
to
d4f38ca
Compare
@OCA/web-maintainers ready to merge I think |
@StefanRijnhart as you blocked the previous PR, can I kindly ask for your review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my concerns on the original PR!
/ocabot merge nobump
On my way to merge this fine PR! |
/ocabot migration web_search_with_and |
Congratulations, your PR was merged at d7b0f0a. Thanks a lot for contributing to OCA. ❤️ |
Standard Migration
@ForgeFlow