-
-
Notifications
You must be signed in to change notification settings - Fork 2k
[18.0][IMP] web_responsive: Quick Record Search #3192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
[18.0][IMP] web_responsive: Quick Record Search #3192
Conversation
Thanks for this new feature. It seems interesting, but I wouldn't say this is something for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mohammedshahil, thank you for your contribution!
Please check the comments below.
@@ -497,6 +500,7 @@ <h2><a class="toc-backref" href="#toc-entry-6">Contributors</a></h2> | |||
<li>Taras Shabaranskyi <<a class="reference external" href="mailto:shabaranskij@gmail.com">shabaranskij@gmail.com</a>></li> | |||
<li>Angel Patel <<a class="reference external" href="mailto:patelangel1414@gmail.com">patelangel1414@gmail.com</a>></li> | |||
<li>Mohamed Alkobrosli <<a class="reference external" href="mailto:malkobrosly@kencove.com">malkobrosly@kencove.com</a>></li> | |||
<li>Mohammed Shahil <<a class="reference external" href="mailto:mohammedshahilmp@gmail.com">mohammedshahilmp@gmail.com</a>></li> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file is auto-generated. Please modify the CONTRIBUTORS file instead. Check the example here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's really good that you have added a screenshot! Please update the USAGE file and add the description of how this feature works in it. You can also embed this gif in it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ivs-cetmix check my comment about the convenience of this feature being here: #3192 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ivs-cetmix check my comment about the convenience of this feature being here: #3192 (comment)
@pedrobaeza yup, that makes sense. I see two options:
- Make search in the same search string that is used now to search for apps (main screen). Then we need to update the web_responsive
- Leave it "as is". In this case yes, this should be a separate module.
@mohammedshahil what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ivs-cetmix check my comment about the convenience of this feature being here: #3192 (comment)
@pedrobaeza yup, that makes sense. I see two options:
* Make search in the same search string that is used now to search for apps (main screen). Then we need to update the web_responsive * Leave it "as is". In this case yes, this should be a separate module.
@mohammedshahil what do you think?
yes separate module is better
Usage
Ctrl+K
)./res.partner John
/sale.order S00001
/product.product Chair
quick_record_search.mp4