8000 [18.0][IMP] web_responsive: Quick Record Search by mohammedshahil · Pull Request #3192 · OCA/web · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[18.0][IMP] web_responsive: Quick Record Search #3192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 18.0
Choose a base branch
from

Conversation

mohammedshahil
Copy link
@mohammedshahil mohammedshahil commented Jun 9, 2025

Usage

  1. Open the command palette (usually with Ctrl+K).
  2. Type the model name and search term, e.g.:
    • /res.partner John
    • /sale.order S00001
    • /product.product Chair
  3. Matching records will be listed. Click a record to open it.
quick_record_search.mp4

@OCA-git-bot
Copy link
Contributor

Hi @Tardo, @SplashS,
some modules you are maintaining are being modified, check this out!

@pedrobaeza
Copy link
Member

Thanks for this new feature. It seems interesting, but I wouldn't say this is something for the web_responsive module. In fact, I think this will work even without installing this module, as the command palette is a native feature, so you should extract it in a module web_command_palette_model_search or similar name. Check also the pre-commit.

Copy link
Member
@ivs-cetmix ivs-cetmix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mohammedshahil, thank you for your contribution!
Please check the comments below.

@@ -497,6 +500,7 @@ <h2><a class="toc-backref" href="#toc-entry-6">Contributors</a></h2>
<li>Taras Shabaranskyi &lt;<a class="reference external" href="mailto:shabaranskij&#64;gmail.com">shabaranskij&#64;gmail.com</a>&gt;</li>
<li>Angel Patel &lt;<a class="reference external" href="mailto:patelangel1414&#64;gmail.com">patelangel1414&#64;gmail.com</a>&gt;</li>
<li>Mohamed Alkobrosli &lt;<a class="reference external" href="mailto:malkobrosly&#64;kencove.com">malkobrosly&#64;kencove.com</a>&gt;</li>
<li>Mohammed Shahil &lt;<a class="reference external" href="mailto:mohammedshahilmp&#64;gmail.com">mohammedshahilmp&#64;gmail.com</a>&gt;</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is auto-generated. Please modify the CONTRIBUTORS file instead. Check the example here.

8000 Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's really good that you have added a screenshot! Please update the USAGE file and add the description of how this feature works in it. You can also embed this gif in it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivs-cetmix check my comment about the convenience of this feature being here: #3192 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivs-cetmix check my comment about the convenience of this feature being here: #3192 (comment)

@pedrobaeza yup, that makes sense. I see two options:

  • Make search in the same search string that is used now to search for apps (main screen). Then we need to update the web_responsive
  • Leave it "as is". In this case yes, this should be a separate module.

@mohammedshahil what do you think?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivs-cetmix check my comment about the convenience of this feature being here: #3192 (comment)

@pedrobaeza yup, that makes sense. I see two options:

* Make search in the same search string that is used now to search for apps (main screen). Then we need to update the web_responsive

* Leave it "as is". In this case yes, this should be a separate module.

@mohammedshahil what do you think?

yes separate module is better

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0