[17.0][FIX] web_m2x_options: prevent crash on Many2OneReferenceField #3205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d8b900b to
cf79f21
Compare
CRogos
reviewed
Jul 3, 2025
Comment on lines
179
to
181
| if (type === "many2one_reference") { | ||
| return props; | ||
| } |
There was a problem hiding this comment.
How about solving this more generic?
Suggested change
| if (type === "many2one_reference") { | |
| return props; | |
| } | |
| if (!this.m2m_options_props){ | |
| return props; | |
| } |
05075ea to
f92463d
Compare
f92463d to
3622e59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
without this patch, calling extractProps on
Many2OneFieldwith type "many2one_reference" to "this.m2o_options_props is not a function" errors because this method is undefinedthis fix adds a no-op m2o_options_props implementation on
Many2OneFieldwith type "many2one_reference" to ensure compatibility and safely bypass the m2o_options_props logic since it's not relevant for reference fieldsto reproduce this bug, open any view with many2one reference field, example automation rule form view with a "Vallues Updated"-trigger
