[18.0][FIX]: web_widget_x2many_2d_matrix: limit options values to x2m… #3200
Conversation
|
Hi @DavidJForgeFlow, @JasminSForgeFlow, |
|
Why this limit? |
|
Because we only tested modules with the changes in the options into many2one fields. And in the original PR I was fixing an error caused by a many2many field getting attributes it won't support. Limiting the options to many2one ensures that no other field type would be affected and, if in a future someone needs this to work on any other type, can simply test and include the type in the method. |
|
@hbrunn should say if this limitation was something in mind when he created the module. |
|
The options feature in v17 and ahead was included by myself and it was only taken into account to many2one fields. I agree that maybe original intention by @hbrunn was getting all the field attributes included by default (as it was happening after the migration to OWL). If his intention is to have all field types being able to get options, first someone would need to adapt how the matrix fields get all the attributes as right now only takes the ones we tested to be able to get. So maybe we could create an issue to don't loose any track of this and as this same features are already in v17.0 we could go ahead with this, what do you think @pedrobaeza ? |
|
OK on my side. |
|
/ocabot merge patch |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 9129bee. Thanks a lot for contributing to OCA. ❤️ |
…any fields.
Improve proposed by @DavidJForgeFlow.
Already merged in 17.0