[FIX] base: trans_implied_ids recursive computation #1306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Install `sale` module 2. In the Odoo shell execute: `env["res.groups"].get_groups_by_application()` *Actual result* `[..., (ir.module.category(52,), 'boolean', res.groups(22, 21, 20), (100, 'Other')) , ...]` *Expected result* `[..., (ir.module.category(52,), 'selection', res.groups(20, 21, 22), (5, 'Sales')) , ...]` *Additional info* The result of `get_groups_by_application` is correct if the computation of `res.groups.trans_implied_ids` is called executing: `env["res.groups"].search([])._compute_trans_implied()`
|
@thomaspaulb here you go, let me know what you think! |
thomaspaulb
approved these changes
Jul 2, 2025
aleuffre
approved these changes
Jul 4, 2025
|
This PR has the |
|
@thomaspaulb can this be merged? thanks! |
|
/ocabot merge patch |
|
not sure if I have rights here |
|
This PR looks fantastic, let's merge it! |
OCA-git-bot
added a commit
that referenced
this pull request
Jul 9, 2025
I believe that if you have the green check ✔️ in Thanks for merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps
salemoduleenv["res.groups"].get_groups_by_application()Actual result
[..., (ir.module.category(52,), 'boolean', res.groups(22, 21, 20), (100, 'Other')) , ...]Expected result
[..., (ir.module.category(52,), 'selection', res.groups(20, 21, 22), (5, 'Sales')) , ...]Additional info
The result of
get_groups_by_applicationis correct if the computation ofres.groups.trans_implied_idsis called executing:env["res.groups"].search([])._compute_trans_implied()Moved here from OCA/server-tools#3320.
I tried to add a test in
salemodule but didn't manage to add a test that would fail without this change.This is already present in
15.0and following versions of Odoo thanks to odoo@34d6f87.