-
-
Notifications
You must be signed in to change notification settings - Fork 257
[17.0][MIG] account_cutoff_base: Migration to 17.0 #284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[17.0][MIG] account_cutoff_base: Migration to 17.0 #284
Conversation
Use assert Remove .keys() No space before colon PEP8/Flake8 : getting closer to compliancy
….get('type', '-')
…de domains) On account.account, type must be <> 'view' and <> 'closed'
…a single warning left ! Add translation template files.
The signature of existing methods is preserved.
Extract a new module account_invoice_start_end_dates from account_cutoff_prepaid
Use triple double quotes for docstring Replace <openerp> by <odoo> in XML Remove <data> tags in XML Remove POT files
Currently translated at 100,0% (73 of 73 strings) Translation: account-closing-11.0/account-closing-11.0-account_cutoff_base Translate-URL: https://translation.odoo-community.org/projects/account-closing-11-0/account-closing-11-0-account_cutoff_base/de/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-closing-16.0/account-closing-16.0-account_cutoff_base Translate-URL: https://translation.odoo-community.org/projects/account-closing-16-0/account-closing-16-0-account_cutoff_base/
Currently translated at 100.0% (134 of 134 strings) Translation: account-closing-16.0/account-closing-16.0-account_cutoff_base Translate-URL: https://translation.odoo-community.org/projects/account-closing-16-0/account-closing-16-0-account_cutoff_base/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-closing-16.0/account-closing-16.0-account_cutoff_base Translate-URL: https://translation.odoo-community.org/projects/account-closing-16-0/account-closing-16-0-account_cutoff_base/
Co-authored-by: Alexis de Lattre <alexis@via.ecp.fr>
fc13845
to
ea6a5e3
Compare
ea6a5e3
to
1811361
Compare
/ocabot migration account_cutoff_base |
/ocabot merge nobump |
On my way to merge this fine PR! |
Congratulations, your PR was merged at e6be133. Thanks a lot for contributing to OCA. ❤️ |
:alt: License: AGPL-3 | ||
.. |badge2| image:: https://img.shields.io/badge/licence-LGPL--3-blue.png | ||
:target: http://www.gnu.org/licenses/lgpl-3.0-standalone.html | ||
:alt: License: LGPL-3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit for migrating the module has included a licence change from AGPL to LGPL. We can't do a silent licence change like this ! It needs to be discussed publically !
ref: BSRD-700