8000 [11.0] Improve performance and do not post reversal entries by grindtildeath · Pull Request #20 · OCA/account-consolidation · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[11.0] Improve performance and do not post reversal entries #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: 11.0
Choose a base branch
from
Open

[11.0] Improve performance and do not post reversal entries #20

wants to merge 6 commits into from

Conversation

grindtildeath
Copy link
Contributor
@grindtildeath grindtildeath commented Jun 3, 2019 •
edited
Loading

  • Improve performance with direct SQL on consolidation flag
    As the consolidated flag is a technical field that is only used during the consolidation
    process to distinct move lines that are already processed from others, we can safely
    bypass the ORM to avoid costly overrides in custom modules that are installed.

  • Improve error message when reversing entries

  • Do not post reversed consolidation entries

  • Reverse again previous consolidation entries if the reversal was deleted

@coveralls
Copy link

Coverage Status

Coverage remained the same at 32.184% when pulling 355587f on grindtildeath:11.0_imp_consolidation_flag_direct_sql into e08dcb2 on OCA:11.0.

@coveralls
Copy link
coveralls commented Jun 3, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.6%) to 31.564% when pulling d86cbd9 on grindtildeath:11.0_imp_consolidation_flag_direct_sql into e08dcb2 on OCA:11.0.

@grindtildeath grindtildeath changed the title [11.0] Improve performance with direct SQL on consolidation flag [11.0] Improve performance and do not post reversal entries Jun 3, 2019
@grindtildeath grindtildeath mentioned this pull request Jun 3, 2019
Merged
@grindtildeath grindtildeath mentioned this pull request Jun 4, 2019
Merged
@grindtildeath
Copy link
Contributor Author

We might have to backport i-vyshnevska@905bcd9 as well here.

@grindtildeath grindtildeath mentioned this pull request Jun 14, 2019
Open
3 tasks
@dreispt
Copy link
Member
dreispt commented Jul 29, 2021

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 11.0-ocabot-merge-pr-20-by-dreispt-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jul 29, 2021
@OCA-git-bot
Merge PR #20 into 11.0
1de353c 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 11.0-ocabot-merge-pr-20-by-dreispt-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@dreispt
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 11.0-ocabot-merge-pr-20-by-dreispt-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Nov 27, 2021
@OCA-git-bot
Merge PR #20 into 11.0
fef7354 
Signed-off-by dreispt
@OCA-git-bot
Copy link
Contributor

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 11.0-ocabot-merge-pr-20-by-dreispt-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@dreispt
8000 Copy link
Member
dreispt commented Oct 1, 2022

/ocabot rebase

grindtildeath and others added 6 commits October 1, 2022 16:00
@grindtildeath @OCA-git-bot
Improve performance with direct SQL on consolidation flag
d26ead1 
As the consolidated flag is a technical field that is only used during the consolidation
process to distinct move lines that are already processed from others, we can safely
bypass the ORM to avoid costly overrides in custom modules that are installed.
@grindtildeath @OCA-git-bot
Improve error message when reversing existing moves
258c147
@OCA-git-bot
[IMP] Add test to check created rvered move lines on consolidation
55df428
@grindtildeath @OCA-git-bot
Fix test on reversed moves
f5302b3
@grindtildeath @OCA-git-bot
[FIX] Do not post reversed consolidation entries
f2a5d2d
@grindtildeath @OCA-git-bot
Ensure reversals of conso entries are regenerated after deletion
fbb6a08
@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 11.0.

@OCA-git-bot OCA-git-bot force-pushed the 11.0_imp_consolidation_flag_direct_sql branch from d86cbd9 to fbb6a08 Compare October 1, 2022 16:00
@oca-clabot
Copy link

Hey @grindtildeath, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: https://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@dreispt
Copy link
Member
dreispt commented May 2, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 11.0-ocabot-merge-pr-20-by-dreispt-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 2, 2024
@OCA-git-bot
Merge PR #20 into 11.0
49042a4 
Signed-off-by dreispt
@dreispt
Copy link
Member
dreispt commented May 11, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 11.0-ocabot-merge-pr-20-by-dreispt-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 11, 2024
@OCA-git-bot
Merge PR #20 into 11.0
5494e20 
Signed-off-by dreispt
@dreispt
Copy link
Member
dreispt commented May 18, 2024

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 11.0-ocabot-merge-pr-20-by-dreispt-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 18, 2024
@OCA-git-bot
Merge PR #20 into 11.0
10553c3 
Signed-off-by dreispt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guewen guewen guewen approved these changes

@i-vyshnevska i-vyshnevska i-vyshnevska approved these changes

Assignees
No one assigned
Labels
approved bot is merging ⏳
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@grindtildeath @coveralls @dreispt @OCA-git-bot @oca-clabot @guewen @i-vyshnevska
0