[18.0][MIG] analytic_brand: Migration to 18.0 #231
Conversation
[UPD] README.rst
[UPD] README.rst [FIX] Fixed travis.
[UPD] Update analytic_brand.pot
Currently translated at 100.0% (2 of 2 strings) Translation: brand-15.0/brand-15.0-analytic_brand Translate-URL: https://translation.odoo-community.org/projects/brand-15-0/brand-15-0-analytic_brand/es/
Currently translated at 100.0% (2 of 2 strings) Translation: brand-17.0/brand-17.0-analytic_brand Translate-URL: https://translation.odoo-community.org/projects/brand-17-0/brand-17-0-analytic_brand/it/
|
@BhaveshHeliconia Can you remove the test dependencies on this one? |
|
@bosd, I removed test file.Please review the PR when you get a chance. |
There was a problem hiding this comment.
The readme / usage instructions could be improved on this one.
- Mention the user has to have analytic account acces rights.
- Go to Configuration -> Settings -> Brands
Select a brand and setup an analytic account.
Please drop the last 2 commits. They do'nt have to be in the modules history.
| # Create a plan (assuming a Plan model exists and is required) | ||
| self.plan = self.env["account.analytic.plan"].create( | ||
| { | ||
| "name": "Test Plan", # Ensure this is the correct model and fields |
There was a problem hiding this comment.
What is this comment for?
| self.analytic_account = self.env["account.analytic.account"].create( | ||
| { | ||
| "name": "Test Analytic Account", | ||
| "plan_id": self.plan.id, # Ensure plan_id is set |
There was a problem hiding this comment.
What is this comment for?
ebbd751 to
5d1d5b1
Compare
|
@bosd, Apologies, this was added by mistake. I’ll make sure to avoid it in the future.Please Review. |
The test-requirements.txt was once needed to pass the test. When the mentioned modules were not merged. But the two commits for editing that file are still in the history. Your text editor will open and show you the last 2 commits. |
5d1d5b1 to
2805e20
Compare
|
@bosd Thanks for the suggestions! I updated. |
|
This PR has the |
|
@BhaveshHeliconia @bosd please have a look at #244 |
Indeed, replacing the analytic account with a distribution is necessary to stay up to date with Odoo's analytics system. I will merge this PR as standard migration and keep the improvement in #244 |
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at cf46350. Thanks a lot for contributing to OCA. ❤️ |
Depends on