8000 [17.0][MIG] contract_queue_job by edescalona · Pull Request #1239 · OCA/contract · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[17.0][MIG] contract_queue_job #1239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Jun 4, 2025
Merged

[17.0][MIG] contract_queue_job #1239

merged 19 commits into from
Jun 4, 2025

Conversation

edescalona
Copy link

@BinhexTeam

Standard migration.

sbejaoui and others added 18 commits May 20, 2025 11:43
@sbejaoui @edescalona
[ADD] - add contract_queue_job and contract_invoice_auto_validate
ab7435d
@edescalona
[IMP] contract_queue_job: jobify renew method for crons
fccfe55
@BurkhalterY @edescalona
[IMP] contract_queue_job: black, isort, prettier
deab78a
@BurkhalterY @edescalona
[MIG] contract_queue_job: Migration to 14.0
07031d5
@edescalona
[UPD] Update contract_queue_job.pot
352ae4f
@OCA-git-bot @edescalona
[UPD] README.rst
05c901b
@OCA-git-bot @edescalona
[UPD] README.rst
da9be91
@Ivorra78 @edescalona
Added translation using Weblate (Spanish)
ed97887
@Ivorra78 @edescalona
Translated using Weblate (Spanish)
fbca14a 
Currently translated at 100.0% (7 of 7 strings)

Translation: contract-14.0/contract-14.0-contract_queue_job
Translate-URL: https://translation.odoo-community.org/projects/contract-14-0/contract-14-0-contract_queue_job/es/
@luisDIXMIT @edescalona
[MIG] contract_queue_job: Migration to 16.0
3201858
@edescalona
[UPD] Update contract_queue_job.pot
ab2229b
@OCA-git-bot @edescalona
[BOT] post-merge updates
571b29e
@weblate @edescalona
Update translation files
aa08926 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: contract-16.0/contract-16.0-contract_queue_job
Translate-URL: https://translation.odoo-community.org/projects/contract-16-0/contract-16-0-contract_queue_job/
@mymage @edescalona
Added translation using Weblate (Italian)
8e4c68b
@mymage @edescalona
Translated using Weblate (Italian)
4505b8b 
Currently translated at 75.0% (3 of 4 strings)

Translation: contract-16.0/contract-16.0-contract_queue_job
Translate-URL: https://translation.odoo-community.org/projects/contract-16-0/contract-16-0-contract_queue_job/it/
@mymage @edescalona
Translated using Weblate (Italian)
73146b5 
Currently translated at 100.0% (4 of 4 strings)

Translation: contract-16.0/contract-16.0-contract_queue_job
Translate-URL: https://translation.odoo-community.org/projects/contract-16-0/contract-16-0-contract_queue_job/it/
@mymage @edescalona
Translated using Weblate (Italian)
e5c7f36 
Currently translated at 100.0% (4 of 4 strings)

Translation: contract-16.0/contract-16.0-contract_queue_job
Translate-URL: https://translation.odoo-community.org/projects/contract-16-0/contract-16-0-contract_queue_job/it/
@edescalona
[IMP] contract_queue_job: pre-commit auto fixes
19c8e64
@edescalona edescalona mentioned this pull request May 20, 2025
Open
16 tasks
@edescalona
Copy link
Author

Ready for review

@rousseldenis
Copy link
Contributor

/ocabot migration contract_queue_job

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Jun 2, 2025
FrancoMaxime
FrancoMaxime approved these changes Jun 3, 2025
View reviewed changes
Copy link
Member
@FrancoMaxime FrancoMaxime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Edescalona for your pr.
Great job, just a minor comment for an old pre-commit stuff.

contract_queue_job/__manifest__.py Outdated
instead of creating all invoices in one transaction""",
"version": "17.0.1.0.0",
"license": "AGPL-3",
"author": "ACSONE SA/NV," "Odoo Community Association (OCA)",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"author": "ACSONE SA/NV," "Odoo Community Association (OCA)",
"author": "ACSONE SA/NV, Odoo Community Association (OCA)",

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@edescalona Could you just attend this quick one ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @FrancoMaxime , I'll correct you, but that's how it was in the base PR. I'll let you know. Thanks.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @FrancoMaxime, ready for review

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes pre-commit stuff do something strange and we have to fix it when we see it. I'm sorry for this

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@edescalona
[MIG] contract_queue_job: Migration to 17.0
51ac851 
[17.0][IMP] contract_queue_job: Update manifest
@edescalona edescalona force-pushed the 17.0-mig-contract_queue_job branch from 14c6cfa to 51ac851 Compare June 3, 2025 12:55
FrancoMaxime
FrancoMaxime approved these changes Jun 3, 2025
View reviewed changes
Copy link
Member
@FrancoMaxime FrancoMaxime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rousseldenis
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 17.0-ocabot-merge-pr-1239-by-rousseldenis-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 0095f7b into OCA:17.0 Jun 4, 2025
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at d21b63b. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rousseldenis rousseldenis rousseldenis approved these changes

@FrancoMaxime FrancoMaxime FrancoMaxime approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review ready to merge
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.
10 participants
@edescalona @rousseldenis @OCA-git-bot @FrancoMaxime @sbejaoui @BurkhalterY @Ivorra78 @luisDIXMIT @weblate @mymage
0