-
-
Notifications
You must be signed in to change notification settings - Fork 358
[18.0][MIG] document_page_reference: Migration to 18.0 #550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.0][MIG] document_page_reference: Migration to 18.0 #550
Conversation
… non-existing reference
[UPD] Update document_page_reference.pot [UPD] README.rst
also, make reference optional in tree view and not the first field.
Currently translated at 100.0% (7 of 7 strings) Translation: knowledge-15.0/knowledge-15.0-document_page_reference Translate-URL: https://translation.odoo-community.org/projects/knowledge-15-0/knowledge-15-0-document_page_reference/it/
Currently translated at 100.0% (7 of 7 strings) Translation: knowledge-15.0/knowledge-15.0-document_page_reference Translate-URL: https://translation.odoo-community.org/projects/knowledge-15-0/knowledge-15-0-document_page_reference/it/
Currently translated at 100.0% (7 of 7 strings) Translation: knowledge-15.0/knowledge-15.0-document_page_reference Translate-URL: https://translation.odoo-community.org/projects/knowledge-15-0/knowledge-15-0-document_page_reference/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: knowledge-16.0/knowledge-16.0-document_page_reference Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_reference/
Currently translated at 100.0% (7 of 7 strings) Translation: knowledge-16.0/knowledge-16.0-document_page_reference Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_reference/es/
Currently translated at 100.0% (7 of 7 strings) Translation: knowledge-16.0/knowledge-16.0-document_page_reference Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_reference/pt/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you review tests and fix it?
WARNING odoo odoo.addons.document_page_reference.models.document_page: Render failed for 16: unexpected char '&' at 11
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The extra commit "[FIX]document_page_reference: render issue fixed" is not necessary, those changes must be added in the migration commit.
rendered = template.render(resolve=record._resolve_reference) | ||
record.content_parsed = rendered | ||
except Exception as e: | ||
_logger.warning("Render failed for %s: %s", record.id, e) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_logger.warning("Render failed for %s: %s", record.id, e) | |
_logger.info("Render failed for %s: %s", record.id, e) |
This change is necessary for the CI to be green.
3ab7672
to
1733c71
Compare
[FIX]document_page_reference :log warning updated [FIX]document_page_reference: null value issue fixed
1733c71
to
7307e19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review OK.
Some non-blocking suggestions.
</field> | ||
</field> | ||
</record> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
</field> | ||
</field> | ||
</record> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
</field> | ||
</field> | ||
</record> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from odoo.tests.common import TransactionCase | ||
|
||
|
||
class TestDocumentReference(TransactionCase): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from odoo.tests.common import TransactionCase | |
class TestDocumentReference(TransactionCase): | |
from odoo.addons.base.tests.common import BaseCommon | |
class TestDocumentReference(BaseCommon): |
Ping @pedrobaeza |
/ocabot migration document_page_reference |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 984f899. Thanks a lot for contributing to OCA. ❤️ |
No description provided.