10000 [18.0][MIG] document_page_reference: Migration to 18.0 by Anushapadinharepurakkal · Pull Request #550 · OCA/knowledge · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[18.0][MIG] document_page_reference: Migration to 18.0 #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Anushapadinharepurakkal

No description provided.

etobella and others added 30 commits June 13, 2025 18:02
[UPD] Update document_page_reference.pot

[UPD] README.rst
also, make reference optional in tree view and not the first field.
Currently translated at 100.0% (7 of 7 strings)

Translation: knowledge-15.0/knowledge-15.0-document_page_reference
Translate-URL: https://translation.odoo-community.org/projects/knowledge-15-0/knowledge-15-0-document_page_reference/it/
Currently translated at 100.0% (7 of 7 strings)

Translation: knowledge-15.0/knowledge-15.0-document_page_reference
Translate-URL: https://translation.odoo-community.org/projects/knowledge-15-0/knowledge-15-0-document_page_reference/it/
Currently translated at 100.0% (7 of 7 strings)

Translation: knowledge-15.0/knowledge-15.0-document_page_reference
Translate-URL: https://translation.odoo-community.org/projects/knowledge-15-0/knowledge-15-0-document_page_reference/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: knowledge-16.0/knowledge-16.0-document_page_reference
Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_reference/
Currently translated at 100.0% (7 of 7 strings)

Translation: knowledge-16.0/knowledge-16.0-document_page_reference
Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_reference/es/
Currently translated at 100.0% (7 of 7 strings)

Translation: knowledge-16.0/knowledge-16.0-document_page_reference
Translate-URL: https://translation.odoo-community.org/projects/knowledge-16-0/knowledge-16-0-document_page_reference/pt/
Copy link
Member
@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you review tests and fix it?

WARNING odoo odoo.addons.document_page_reference.models.document_page: Render failed for 16: unexpected char '&' at 11

Copy link
Member
@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extra commit "[FIX]document_page_reference: render issue fixed" is not necessary, those changes must be added in the migration commit.

rendered = template.render(resolve=record._resolve_reference)
record.content_parsed = rendered
except Exception as e:
_logger.warning("Render failed for %s: %s", record.id, e)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
_logger.warning("Render failed for %s: %s", record.id, e)
_logger.info("Render failed for %s: %s", record.id, e)

This change is necessary for the CI to be green.

@Anushapadinharepurakkal Anushapadinharepurakkal force-pushed the 18.0-mig-document_page_reference branch from 3ab7672 to 1733c71 Compare July 2, 2025 04:47
[FIX]document_page_reference :log warning updated

[FIX]document_page_reference: null value issue fixed
@Anushapadinharepurakkal Anushapadinharepurakkal force-pushed the 18.0-mig-document_page_reference branch from 1733c71 to 7307e19 Compare July 2, 2025 04:53
Copy link
Member
@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review OK.

Some non-blocking suggestions.

</field>
</field>
</record>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

</field>
</field>
</record>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

</field>
</field>
</record>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Comment on lines +5 to +8
from odoo.tests.common import TransactionCase


class TestDocumentReference(TransactionCase):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from odoo.tests.common import TransactionCase
class TestDocumentReference(TransactionCase):
from odoo.addons.base.tests.common import BaseCommon
class TestDocumentReference(BaseCommon):

@victoralmau
Copy link
Member

Ping @pedrobaeza

@pedrobaeza
Copy link
Member

/ocabot migration document_page_reference
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Jul 8, 2025
@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-550-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot mentioned this pull request Jul 8, 2025
10 tasks
@OCA-git-bot OCA-git-bot merged commit 3b6e9e6 into OCA:18.0 Jul 8, 2025
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 984f899. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0