-
-
Notifications
You must be signed in to change notification settings - Fork 895
[17.0][MIG] partner_data_vies_populator #2025
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jdidderen
wants to merge
16
commits into
OCA:17.0
Choose a base branch
from
jdidderen:17.0-mig-partner_data_vies_populator
base: 17.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[17.0][MIG] partner_data_vies_populator #2025
jdidderen
wants to merge
16
commits into
OCA:17.0
from
jdidderen:17.0-mig-partner_data_vies_populator
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
099867a
to
7c76be9
Compare
7c76be9
to
0e01de3
Compare
Improve error handling to avoid crash when Internet connectivity is down Read country code from VIES, not from VAT number No update when VAT number is invalid Improve tests
Currently translated at 100.0% (5 of 5 strings) Translation: partner-contact-14.0/partner-contact-14.0-partner_data_vies_populator Translate-URL: https://translation.odoo-community.org/projects/partner-contact-14-0/partner-contact-14-0-partner_data_vies_populator/fr/
0e01de3
to
fbe0876
Compare
bosd
approved these changes
Apr 8, 2025
coleste
approved these changes
Jun 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
multi-line string with aggregate street, zip and city. | ||
|
||
So, when the data is retrieved, it will try to populate the *City* and | ||
*Zip* fields from the last line of the address. T he *Street* field will |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extra space in The Street
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the work made in #1642