8000 [16.0][MIG] pos_pricelist_technical by legalsylvain · Pull Request #1130 · OCA/pos · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[16.0][MIG] pos_pricelist_technical #1130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jun 4, 2024

Conversation

legalsylvain
Copy link
@legalsylvain legalsylvain commented Jan 16, 2024
  • migration from 12.0 version. (related PR)

Description

This module extends the functionality of Point of Sale to prevent technical pricelists that are used for the computation of other pricelists from being selected.

Configure

  • First configure the main module sale_pricelist_technical.

  • Configure your pricelist on your pos config form.

pos_config_form

Usage

pos_front_end_ui

@legalsylvain
Copy link
Author

/ocabot migration pos_pricelist_technical

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jan 16, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 16, 2024
38 tasks
@legalsylvain legalsylvain force-pushed the 16.0-mig-pos_pricelist_technical branch from d6a57aa to 7f4f486 Compare January 16, 2024 23:48
@legalsylvain legalsylvain force-pushed the 16.0-mig-pos_pricelist_technical branch from 7f4f486 to cd913cd Compare January 27, 2024 09:02
Copy link
@quentinDupont quentinDupont le 8000 ft a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey !
Why not hiding technical pricelist directly on pos.config ?
thanks for this PR and migration

@legalsylvain
Copy link
Author

Why not hiding technical pricelist directly on pos.config ?

Do you mean, removing the pricelist from the field available_pricelist_ids ? If yes :

Considering

  • Pricelist 1
  • Pricelist 2 (IS TECHNICAL = Should not be used on a sale for customer)
  • Pricelist 3, based on pricelist 2

If you don't load the pricelist 2 in the pos.config, it will not be available in the PoS. As a result the computation of the pricelist 3 will fail, because information are not available.

@quentinDupont
Copy link

If you don't load the pricelist 2 in the pos.config, it will not be available in the PoS. As a result the computation of the pricelist 3 will fail, because information are not available.

Ok i didn't know !
Thanks for the explanation :)

Copy link
@quentinDupont quentinDupont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functionnal and code review, thank you for this migration ✔️

Copy link
github-actions bot commented Jun 2, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 2, 2024
@legalsylvain
Copy link
Author

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1130-by-legalsylvain-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jun 3, 2024
Signed-off-by legalsylvain
@OCA-git-bot
Copy link
Contributor

@legalsylvain your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1130-by-legalsylvain-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

legalsylvain and others added 13 commits June 4, 2024 16:08
Avoid to display in the point of sale pricelists that are used only to compute other pricelist
Co-authored-by: Carmen Bianca Bakker <carmen@carmenbianca.eu>
Co-authored-by: Carmen Bianca Bakker <carmen@carmenbianca.eu>
Co-authored-by: Pierre Verkest <pierreverkest84@gmail.com>
Currently translated at 100.0% (4 of 4 strings)

Translation: pos-12.0/pos-12.0-pos_pricelist_technical
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_pricelist_technical/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: pos-12.0/pos-12.0-pos_pricelist_technical
Translate-URL: https://translation.odoo-community.org/projects/pos-12-0/pos-12-0-pos_pricelist_technical/
@legalsylvain legalsylvain force-pushed the 16.0-mig-pos_pricelist_technical branch from cd913cd to 1d094c8 Compare June 4, 2024 14:08
@legalsylvain
Copy link
Author

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1130-by-legalsylvain 8000 -bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 37da774 into OCA:16.0 Jun 4, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f800332. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged 🎉 stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0