8000 [17.0][MIG] project_task_code by etobella · Pull Request #1499 · OCA/project · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[17.0][MIG] project_task_code #1499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 68 commits into from
May 20, 2025
Merged

Conversation

etobella
Copy link
Member

Superseed of #1355

Restore the kanban as it was....

image

@etobella etobella changed the title [17.0][MIG] project_code [17.0][MIG] project_task_code May 12, 2025
@etobella
Copy link
Member Author

/ocabot migration project_task_code

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone May 12, 2025
@OCA-git-bot OCA-git-bot mentioned this pull request May 12, 2025
34 tasks
@pedrobaeza
Copy link
Member

/ocabot migration project_task_code

@pedrobaeza
Copy link
Member

There's a merge commit inside the commit history. You should do a rebase and remove it.

oihane and others added 23 commits May 12, 2025 08:32
OCA Transbot updated translations from Transifex

[MIG] project_task_code: Migrate to 10.0

Edit init and XML

Add env

Change task_ids to tasks

Change to @api.multi before def copy
Relational fields and the task notification email inform the task code
- adapted view (label needs a `for` attribute, use span for same result)
- use the `model_create_multi` decorator on the create override for
future-proofiness
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Currently translated at 100.0% (3 of 3 strings)

Translation: project-12.0/project-12.0-project_task_code
Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_task_code/gl/
@etobella etobella force-pushed the 17.0-mig-project_code branch from 167d69d to 46ba993 Compare May 12, 2025 06:32
Copy link
@AaronHForgeFlow AaronHForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works ok!

Comment on lines 47 to 48
for task in self:
task.display_name = f"[{task.code}] {task.name}" if task.code else task.name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make it like this?

Suggested change
for task in self:
task.display_name = f"[{task.code}] {task.name}" if task.code else task.name
super()._compute_display_name()
for task in self:
if task.code:
task.display_name = f"[{task.code}] {task.display_name}"
return

Related: #1502 #1503

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yostashiro you are completly right. I made a small change to adapt to your suggestion 😉

Copy link
Contributor
@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few minor changes if you consider them applicable.

TT54672

@etobella etobella force-pushed the 17.0-mig-project_code branch 2 times, most recently from 489a52d to ac958e4 Compare May 19, 2025 19:03
@pedrobaeza
Copy link
Member

Please check CI

@etobella etobella force-pushed the 17.0-mig-project_code branch from ac958e4 to 963be7a Compare May 20, 2025 04:39
@etobella
Copy link
Member Author

Fixed! It was a collision with another module. The way to solve it was to check the name by regex 😉

Copy link
Member
@yostashiro yostashiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-1499-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 2f0ea40 into OCA:17.0 May 20, 2025
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8b33ed1. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0