-
-
Notifications
You must be signed in to change notification settings - Fork 825
[17.0][MIG] project_task_code #1499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/ocabot migration project_task_code |
/ocabot migration project_task_code |
There's a merge commit inside the commit history. You should do a rebase and remove it. |
OCA Transbot updated translations from Transifex [MIG] project_task_code: Migrate to 10.0 Edit init and XML Add env Change task_ids to tasks Change to @api.multi before def copy
Relational fields and the task notification email inform the task code
- adapted view (label needs a `for` attribute, use span for same result) - use the `model_create_multi` decorator on the create override for future-proofiness
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
Currently translated at 100.0% (3 of 3 strings) Translation: project-12.0/project-12.0-project_task_code Translate-URL: https://translation.odoo-community.org/projects/project-12-0/project-12-0-project_task_code/gl/
Currently translated at 100.0% (4 of 4 strings) Translation: project-16.0/project-16.0-project_task_code Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_code/it/
Currently translated at 100.0% (4 of 4 strings) Translation: project-16.0/project-16.0-project_task_code Translate-URL: https://translation.odoo-community.org/projects/project-16-0/project-16-0-project_task_code/pt_BR/
Search task by its code in x2m fields.
167d69d
to
46ba993
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works ok!
for task in self: | ||
task.display_name = f"[{task.code}] {task.name}" if task.code else task.name |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yostashiro you are completly right. I made a small change to adapt to your suggestion 😉
46ba993
to
68cfa1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few minor changes if you consider them applicable.
TT54672
489a52d
to
ac958e4
Compare
Please check CI |
ac958e4
to
963be7a
Compare
Fixed! It was a collision with another module. The way to solve it was to check the name by regex 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
/ocabot merge nobump |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 8b33ed1. Thanks a lot for contributing to OCA. ❤️ |
Superseed of #1355
Restore the kanban as it was....