8000 [16.0] auto_backup: TypeError: makedirs() got an unexpected keyword argument 'exist_ok' · Issue #3139 · OCA/server-tools · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[16.0] auto_backup: TypeError: makedirs() got an unexpected keyword argument 'exist_ok' #3139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
santiky opened this issue Dec 7, 2024 · 0 comments
Open

[16.0] auto_backup: TypeError: makedirs() got an unexpected keyword argument 'exist_ok' #3139

santiky opened this issue Dec 7, 2024 · 0 comments
Labels
bug

Comments

@santiky
Copy link
santiky commented Dec 7, 2024 •
edited
Loading

Module

auto_backup 16.0

Describe the bug

This bug is the same than pull request #2902 in 12.0 branch but recent changes 3d39f2b has reintroduced it in 16.0 branch.

Trying to make a backup in a remote sftp server, throws this error:

Odoo Server 16.0:odoo:ERROR:odoo.addons.auto_backup.models.db_backup:Database backup failed: sftp://user@example.com:22
Traceback (most recent call last):
File "/opt/odoo/addons-oca/auto_backup/models/db_backup.py", line 215, in backup_log
yield
File "/opt/odoo/addons-oca/auto_backup/models/db_backup.py", line 189, in action_backup
remote.makedirs(rec.folder, exist_ok=True)
TypeError: Connection.makedirs() got an unexpected keyword argument 'exist_ok'

and it does not complete the backup transfer.

To Reproduce

Affected versions: Only 16.0,

Steps to reproduce the behavior:

  1. Setup a backup in a remote server.
  2. Make one backup, it fails.

Additional context
Pysftp method makedirs() it does not have any argument, it's different than the os.makedirs method.
https://pysftp.readthedocs.io/en/release_0.2.9/cookbook.html#pysftp-connection-makedirs
Removing "exist_ok" on line 189 solves the error.

server-tools/auto_backup/models/db_backup.py

Line 189 in 6e7e03d

remote.makedirs(rec.folder, exist_ok=True)

Regards.
@santiky santiky added the bug label Dec 7, 2024
ignaciord added a commit to ignaciord/server-tools that referenced this issue Mar 4, 2025
@ignaciord
Bugfix: exist_ok parameter does not exists in remote.makedirs() function
6b352ff 
As said on OCA#3139 there is no exist_ok parameter in remote.makedirs() function.
@ignaciord ignaciord mentioned this issue Mar 4, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@santiky
0