[14.0][FIX] excel_import_export: external ids naming. #2283
Conversation
Because of the naming given to the external ID's, Odoo interprets all this data as regular module data and when you update the module and those external ID's are not present in the module files, it tries to delete them.
There was a problem hiding this comment.
This fix prevents the deletion of the records since excel_import_export is a non-existing module name.
But I think we should be consistent and hence change also the following line accordingly:
or "{}.{}".format("xls", uuid.uuid4()) : xls -> __excel_import_export
Otherwise we have two different module names in the xml_id for records updated or created by the excel_import_export module.
|
In commit there is |
|
I thought for FW port it is correct like this, just pull the commit here. No? |
|
Oh well. I don't catch that. Maybe that's correct |
fix from PR OCA#2283 together with @luc-demeyer suggestion OCA#2283 (review)
|
This PR is approved by 2 reviewers. Can we merge it? |
fix from PR OCA#2283 together with @luc-demeyer suggestion OCA#2283 (review)
fix from PR OCA#2283 together with @luc-demeyer suggestion OCA#2283 (review)
fix from PR OCA#2283 together with @luc-demeyer suggestion OCA#2283 (review)
fix from PR OCA#2283 together with @luc-demeyer suggestion OCA#2283 (review)
fix from PR OCA#2283 together with @luc-demeyer suggestion OCA#2283 (review)
fix from PR OCA#2283 together with @luc-demeyer suggestion OCA#2283 (review)
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
FW Port from #1899
Because of the naming given to the external ID's, Odoo
interprets all this data as regular module data and when
you update the module and those external ID's are not present
in the module files, it tries to delete them.