[16.0][FIX] fetch...folder: use message uid's not sequence #3017
Conversation
4b32c32 to
b6d4114
Compare
|
@zamberjo Can you have a look at this? |
|
As highlighted in PR #3222, the reverse processing of emails aims to address a similar issue to the one you're working on here. But I fail to see the exact modification you are doing in this PR to retreive UID instead of sequences. It's probably lost in all the variable renames. |
|
@ikus060 I introduce the variable name message_uid instead of msgid, because it is a really different thing. msgid is basically the position of the message in the imap folder, and gets updated all the time because of insertions and deletions. message_uid however is constant (as long as the message remains in the same folder). However to work with the uid's the methods to work with messages are replaced by a single method on the connection, uid, with the original methodname as the first parameter: |
|
ok, I see I've missed that while looking at the changes. Thanks for pointing the changes. |
7b95d09 to
02e69ba
Compare
|
This PR has the |
|
/ocabot merge minor |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 141d0a2. Thanks a lot for contributing to OCA. ❤️ |
When archiving messages, the messages get a new sequence through renumbering. To solve the problems this causes use the message uid's that are garanteed to remain constant for a message within a folder.