-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[16.0][MIG] base_model_restrict_update: Migration to 16.0 #3150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 16.0
Are you sure you want to change the base?
[16.0][MIG] base_model_restrict_update: Migration to 16.0 #3150
Conversation
This one supersedes #3134. |
#: code:addons/base_model_restrict_update/models/res_users.py:0 | ||
#, python-format | ||
msgid "You cannot make the admin user read-only." | ||
msgstr "管理者ユーザは読取専用にできません。" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
msgstr "管理者ユーザは読取専用にできません。" | |
msgstr "管理者ユーザは読取専用にできません。" | |
0abac53
to
3cca3ee
Compare
3cca3ee
to
ae16729
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review: LGTM
ae16729
to
ffea181
Compare
Before this commit, button presentation of 'Grant Update Permit' and 'Readonly' were broken in the user form with the deprecation of boolean_button widget. In this commit, we switch to use boolean_toggle for these buttons, with some other style adjustments on the buttons.
Currently translated at 100.0% (13 of 13 strings) Translation: server-tools-15.0/server-tools-15.0-base_model_restrict_update Translate-URL: https://translation.odoo-community.org/projects/server-tools-15-0/server-tools-15-0-base_model_restrict_update/es_AR/
ffea181
to
c4d7f4c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash the last two commits into one.
c4d7f4c
to
5359b6a
Compare
…llow read-only exception models Previously, the exemption for the model update restriction was given by setting unrestrict_model_update to the relevant users. However, this design had the limitation of not being able to control the permitted users per model. This commit addresses this limitation by adding the update_allowed_group_ids field to ir.model, removing the unrestrict_model_update field from res.users. This commit also contains the following changes: - Make the logic of _check_is_readonly_user() more complete. - Refactor tests to make them more comprehensive. - Add the flexibility of allowing certain models to be excluded from being read-only even when the user is set as read-only.
5359b6a
to
69a3fea
Compare
@yostashiro Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This module has been in production use for a while.
This PR has the |
@qrtl QT4777