[18.0][MIG] base_import_security_group #1011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This module makes importing data from CSV files optional for each user, allowing it only for those users belonging to a specific group. [FIX] Solved flake8 error E305: expected 2 blank lines after class or function definition, found 1 [FIX] Renamed base_import_csv_optional in base_import_security_group [FIX] Solved flake8 error E501: line too long; [FIX] Removed unnecessary monkeypatch and extended Base.load method; [FIX] Bugfixing in Base.load method; [FIX] Code refactoring [IMP] Tests created
[FIX] Updated travis postgresql version [FIX] Updated phantom_js version in travis [FIX] Configured travis to run tests for this module in isolation mode [FIX] Configured travis to run tests for this module in isolation mode [FIX] Added group to demo_user for test purposes [FIX] Changed waiting condition on Phantom JS test [FIX] Removed Travis configuration for isolated test environment [FIX] Changed waiting condition in phantom_js test [FIX] Changed target action in phantom_js test [FIX] Changed target action in phantom_js test
OCA Transbot updated translations from Transifex [UPD] Update base_import_security_group.pot [UPD] Update base_import_security_group.pot [UPD] README.rst
[UPD] Update base_import_security_group.pot [UPD] README.rst
* Patch existing class instead of duplicating it, for better compatibility with other modules enhancing the same class. * To circumvent problems executing async calls in a non-widget class, pass the user's import permission through the web session. * Adapt tests to consult he Favorite dropdown in the 14.0 GUI. * In the tour, don't target the Users menu which is the default menu of the Settings menu when no other module is installed, and in that case clicking the menu in the tour is a void action that makes the tests fail. Target the Companies menu item instead. [UPD] Update base_import_security_group.pot [UPD] README.rst
[UPD] Update base_import_security_group.pot [UPD] README.rst
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: server-ux-15.0/server-ux-15.0-base_import_security_group Translate-URL: https://translation.odoo-community.org/projects/server-ux-15-0/server-ux-15-0-base_import_security_group/
When the web_responsive module is installed, the tests fail when looking for "Settings" in the menu, because you have to access the menu first to get that option. Adding the extra step to display the menu is the right option so that the tests don't fail whether the web_responsive module is installed or not. TT42822
Currently translated at 100.0% (3 of 3 strings) Translation: server-ux-16.0/server-ux-16.0-base_import_security_group Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_import_security_group/es/
Currently translated at 100.0% (2 of 2 strings) Translation: server-ux-16.0/server-ux-16.0-base_import_security_group Translate-URL: https://translation.odoo-community.org/projects/server-ux-16-0/server-ux-16-0-base_import_security_group/it/
4bbbb9e to
bda539a
Compare
bda539a to
c8661a7
Compare
|
/ocabot migration base_import_security_group |
c8661a7 to
1440cb0
Compare
bizzappdev
reviewed
Apr 17, 2025
| each user, depending on whether Import CSV/Excel files is ticked on the | ||
| Access Rights tab on the user form. This corresponds to a user group by | ||
| the same name. Only users that belong to this group will have the Import 8000 | ||
| records button available under the Favorites button of each list or |
There was a problem hiding this comment.
Suggested change
| records button available under the Favorites button of each list or | |
| records button available under the Settings icon of each list or |
There was a problem hiding this comment.
Good catch! But maybe it should be replaced with 'Actions icon', right?
1440cb0 to
55872ec
Compare
bizzappdev
approved these changes
Apr 17, 2025
sebalix
approved these changes
May 13, 2025
|
/ocabot merge nobump |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at 638fed6. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on unmerged #1010
JS tour tests: update selectors