[18.0][MIG] base_tier_validation_formula: Migration to 18.0 #1028
Conversation
fixup and extend tests [ADD] systray icon for pending reviews [FIX] Remove python safe_eval [ADD] base_tier_validation_formula and migration scripts [ADD] widget domain and python expression to define reviewer in tier definition [ADD] auto updating of systray icon counter [ADD] validation date field [ADD] review widget dropdown menu
There was a problem hiding this comment.
Supersedes #1021
Please squash administrative commits according to https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests.
The last commit [IMP] base_tier_validation_formula: pre-commit auto fixes should be split into two commits:
- One for pre-commit fixes (only if running
pre-commit run -aproduces changes, otherwise this commit can be skipped, and the next commit will handle the migration). - Another for the migration
Reference: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0
If you have any questions, let me know.
TT54137
@Tecnativa
Currently translated at 100.0% (17 of 17 strings) Translation: server-ux-12.0/server-ux-12.0-base_tier_validation_formula Translate-URL: https://translation.odoo-community.org/projects/server-ux-12-0/server-ux-12-0-base_tier_validation_formula/zh_CN/
[UPD] Update base_tier_validation_formula.pot
… in tier definitions [UPD] Update base_tier_validation_formula.pot
[UPD] Update base_tier_validation_formula.pot
[UPD] Update base_tier_validation_formula.pot
- Include context keys for avoiding mail operations overhead.
8f28a1c to
6870a73
Compare
|
@absal-smile I noticed this is your first contribution—welcome to the great OCA ecosystem! 🎉 Please remember to sign your CLA according to this guide to ensure GitHub Actions run successfully. Thanks for your contribution! 🚀. If you have any questions, feel free to let me know. |
|
@carlos-lopez-tecnativa I am currently working at Smile and I am part of the Odoo Smile team. I would like to be included in the Smile ICLA to avoid requiring approval for every workflow individually. |
|
@vdewulf he sent the CLA request some weeks ago. Marking the corresponding partner tag, there's an automatism for synchronizing the members of GitHub to not require GH actions approval for each commit/PR. |
|
@absal-smile please check the CI, |
6870a73 to
a3cee52
Compare
There was a problem hiding this comment.
Tested locally, LGTM.
@bosd @StefanRijnhart, could you please review this? Thanks in advance.
Non-blocking comment: some administrative commits can be squashed.
| from odoo.addons.base.tests.common import BaseCommon | ||
|
|
||
|
|
||
| # Use Base Common |
There was a problem hiding this comment.
This comment is irrelevant; it could be removed.
@pedrobaeza I think sync was not done before PR creation (signed 20th, created 21st). We'll see for further PR's |
|
ping @bosd @StefanRijnhart |
|
LGTM, A bit of nit picking.. |
|
/ocabot migration base_tier_validation_formula |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at 8c296a2. Thanks a lot for contributing to OCA. ❤️ |
sergio-teruel
carlos-lopez-tecnativa
No description provided.