[FIX] fs_storage: test connection by creating a hidden file #478
Conversation
fs_storage_fix_2.mp4 |
41ebc7c to
42c071e
Compare
|
This is only failing on s3. I am not sure if it makes sense (also, you are requiring a test bucket, I don't know if it makes sense). |
ok, I am using s3 cloudflare in my test a real prod. s3 I agree with no it does not make sense, but why do't we approve the commit? |
fs_storage/models/fs_storage.py
Outdated
| @@ -290,11 +290,14 @@ def _get_marker_file_name(self): | |||
| return ".odoo_fs_storage_%s.marker" % self.id | |||
|
|
|||
| def _marker_file_check_connection(self, fs): | |||
| bucket_name = "test" | |||
| fs.makedirs(bucket_name, exist_ok=True) | |||
There was a problem hiding this comment.
Sorry but I don't see the point here. This code makes no sens to me.
There was a problem hiding this comment.
what if someone run test connection and get the error?
There was a problem hiding this comment.
the point is you have to specify dir name not just file name
if you don't like creating a test dir, then there must be a value for path directory and be used in test connection.
in any case dir name must be specified.
There was a problem hiding this comment.
In this case, it is more useful to add a comment in order to ask the user to check both of them, as there are false negatives some times
There was a problem hiding this comment.
I will try something more meaningful
42c071e to
3802f38
Compare
the lis opton in test connection is fine, but the create option was not functionnning correctly.