[data-1994] Remove parquet support from datamart plugin #201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes Parquet snapshot functionality from the Datamart plugin, simplifying the flow to only support schema snapshots and cleaning up related utilities.
- Drop
CREATE_PARQUET_SNAPSHOTenum and all Parquet-related branches - Remove Minio DAO, upload helper, and Pandas/time imports
- Simplify
copy_schemasignature anddatamart_pluginmatch logic
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| flows/base/datamart_plugin/types.py | Removed CREATE_PARQUET_SNAPSHOT action |
| flows/base/datamart_plugin/flow.py | Removed Parquet imports, branches, and helper function; updated match and copy_schema signature |
| flows/_shared_flow_utils/dao/MinioDao.py | Deleted entire file, dropping Parquet upload support |
Comments suppressed due to low confidence (3)
flows/base/datamart_plugin/flow.py:18
- Add a default
case _:branch to the match onoptions.flow_action_typeto explicitly handle unsupported action types and fail fast.
match options.flow_action_type:
flows/base/datamart_plugin/flow.py:87
- [nitpick] Consider adding explicit type annotations for
copy_schemaparameters and return value to improve readability and editor support.
@task(log_prints=True)
flows/base/datamart_plugin/flow.py:20
- Add or update unit/integration tests to verify that only
CREATE_SNAPSHOTis supported and that using the removedCREATE_PARQUET_SNAPSHOTraises an appropriate error.
case DatamartFlowAction.CREATE_SNAPSHOT:
csafreen
reviewed
May 27, 2025
…nto alicia-koh/data-1994
csafreen
approved these changes
May 29, 2025
Signed-off-by: alicia-koh <110385419+alicia-koh@users.noreply.github.com>
SantanM
approved these changes
Jun 3, 2025
p-hoffmann
approved these changes
Jun 3, 2025
csafreen
pushed a commit
that referenced
this pull request
Jun 4, 2025
* Remove parquet support from datamart plugin * Remove minio in other plugins requirements.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist
Please cross check this list if additions / modifications needs to be done on top of your core changes and tick them off. Reviewer can as well glance through and help the developer if something is missed out.
developbranch)