Remove publication & fix health check #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Hoffmann <954078+p-hoffmann@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR removes the publications block from the JSON payload sent by load-demodatabase.mjs.
- Deletes the
publicationsarray and its entries from the payload - Leaves only the
vocabSchemasandauthenticationModeproperties
Comments suppressed due to low confidence (2)
scripts/load-demodatabase.mjs:175
- Add or update automated tests to validate that the payload no longer contains the
publicationsfield and that downstream behavior remains correct.
],
scripts/load-demodatabase.mjs:177
- Update any related documentation or README entries to reflect that the
publicationsfield is no longer supported in the payload.
"authenticationMode": "Password"
Signed-off-by: Peter Hoffmann <954078+p-hoffmann@users.noreply.github.com>
Signed-off-by: Peter Hoffmann <954078+p-hoffmann@users.noreply.github.com>
Signed-off-by: Peter Hoffmann <954078+p-hoffmann@users.noreply.github.com>
satish-a0
approved these changes
May 29, 2025
mwaiyee
approved these changes
May 30, 2025
SantanM
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist
Please cross check this list if additions / modifications needs to be done on top of your core changes and tick them off. Reviewer can as well glance through and help the developer if something is missed out.
developbranch)