8000 Bugon 1484 v4 by catenacyber · Pull Request #13543 · OISF/suricata · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bugon 1484 v4 #13543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bugon 1484 v4 #13543

wants to merge 2 commits into from
+116 −97

Conversation

catenacyber
Copy link
Contributor

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/1484

Describe changes:

  • remove BUG_ON in packet path
  • remove direct abort in favor of macros

Methodology : run SV with modified suricata with commit catenacyber@a8b56a2

gather all BUG_ON files and lines with grep -r "lol BUG" tests/ | cut -d: -f2- | sort | uniq

Then run some

f = open("lol2.txt")
for l in f.readlines():
    # sed -i -e '343s/BUG_ON/DEBUG_VALIDATE_BUG_ON/' src/app-layer-htp.c
    print("sed -i -e '%ss/BUG_ON/DEBUG_VALIDATE_BUG_ON/' src/%s" % (l.split()[1], l.split()[0]))

#13537 with clean history

8000
@catenacyber
src: remove direct calls to abort
4f8e9c5 
use BUG_ON macros instead

Ticket: 1484
@catenacyber
src: remove BUG_ON in packet path
fd665c4 
Transforms them into debug validations

Ticket: 1484

Packet path is here considered FlowWorker and all lines
covered by SV tests are here fixed
@catenacyber catenacyber mentioned this pull request Jun 27, 2025
Closed
@codecov Codecov
Copy link
codecov bot commented Jun 27, 2025

Codecov Report

Attention: Patch coverage is 97.75281% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.49%. Comparing base (f26f750) to head (fd665c4).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master   #13543      +/-   ##
==========================================
- Coverage   83.50%   83.49%   -0.01%     
==========================================
  Files        1011     1011              
  Lines      274904   274891      -13     
==========================================
- Hits       229563   229526      -37     
- Misses      45341    45365      +24
Flag Coverage Δ
fuzzcorpus 61.80% <81.70%> (+0.01%) ⬆️
livemode 18.96% <15.47%> (+<0.01%) ⬆️
pcap 44.66% <48.80%> (-0.01%) ⬇️
suricata-verify 65.07% <96.42%> (+<0.01%) ⬆️
unittests 59.14% <29.88%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline = 26657

@victorjulien victorjulien added this to the 8.0 milestone Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorjulien victorjulien victorjulien approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@catenacyber @suricata-qa @victorjulien
0