Smtp inspection fix/v2 #13507
Closed
Smtp inspection fix/v2 #13507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As a part of ab01a1b, in order to match the behavior in master, the calls for triggering raw stream inspection were made when communication in one direction for a transaction was completed. However, it was incorrect to do so. Reliable inspection requires any request/response to be completed. Hence, fix the behavior and make it consistent with all the other applayer parsers. SMTP parser can handle multiple command lines per direction. Appropriate calls to trigger raw stream inspection have been added on succesful parsing of each request and response line. Bug 7783
ac90fc5 to
721b239
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #13507 +/- ##
==========================================
- Coverage 83.48% 83.47% -0.01%
==========================================
Files 1011 1011
Lines 274902 274901 -1
==========================================
- Hits 229507 229485 -22
- Misses 45395 45416 +21
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Information: QA ran without warnings. Pipeline = 26582 |
catenacyber
reviewed
Jun 25, 2025
catenacyber
reviewed
Jun 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/7783
Restores behavior from the past rejected PR b4c51d3 as that was correct.
Previous PR: #13505
Changes since v1:
NOTE: Requires upgrading of at least one internal test.