flowbits: add a validation callback during setup #13508
Draft
+23
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should make it possible to catch invalid combinations in the same signature early. This patch covers checking set and isset commands on the same flowbit in the same signature which is basically an unnecessary operation. Bug 7772
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #13508 +/- ##
=======================================
Coverage 83.48% 83.49%
=======================================
Files 1011 1011
Lines 274902 274919 +17
=======================================
+ Hits 229507 229530 +23
+ Misses 45395 45389 -6
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Information: QA ran without warnings. Pipeline = 26579 |
catenacyber
reviewed
Jun 25, 2025
| continue; | ||
| /* Check if an entry corresponding to the same idx exists in the opposite list */ | ||
| DetectFlowbitsData *fd2 = (DetectFlowbitsData *)sm->ctx; | ||
| if (fd2->idx == fd->idx) { |
There was a problem hiding this comment.
should we have a more explicit check about fd2->cmd ?
There was a problem hiding this comment.
indeed that'll be better. this leaves scope for bugs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/7772
SV_BRANCH=OISF/suricata-verify#2579
This is pretty trivial patch which just throws a warning for now. If acceptable, other invalid combination checks will follow in another PR.