Add interpolation to powder fill example #213
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,38 @@ | |||
|
|
|||
There was a problem hiding this comment.
This function misses the copyright notice.
Also, it seems the ability to interpolate would be helpful for other fields, not just density.
| @@ -479,7 +479,7 @@ class Particles<MemorySpace, PMB, TemperatureIndependent, BaseOutput, Dimension> | |||
| v( pid, d ) = 0.0; | |||
| f( pid, d ) = 0.0; | |||
| } | |||
| type( pid ) = 0; | |||
| type( pid ) = 1; | |||
There was a problem hiding this comment.
Why changing type from 0 to 1?
Why rho = 1 below?
|
In powder_fill.json, we have: Should these include units? |
| // ==================================================== | ||
| // Interpolate for consolidation | ||
| // ==================================================== | ||
| // Do this first to get the coarser grid. |
There was a problem hiding this comment.
Does this example suppose to run the powder setting first and then interpolate the final density profile and output to a file? (just making sure I understand)
Also, any reason to choose a coarser grid of half the number of cells per dimension? Is this an arbitrary choice?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Powder to continuum demonstration
Before merging
typefield vs physical/relative density