DRAFT: Add option to disable Passenger telemetry (https://github.com/OSC/ondemand/issues/4347) #271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With the new setting merge in the ondemand repo, we should be good to merge this PR. I presume your tests will get updated with new releases, so we will have to wait for the next official release for them to succeed? |
Yea we have to wait until 4.0.4 comes out. |
|
Should be soon, I think I have everything I want to put in it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the option to disable the Passenger telemetry as requested in OSC/ondemand#4347.
It is for now marked as draft since it requires changes to the ondemand repository being merged first in PR OSC/ondemand#4355
This PR includes changes in the previous PR #270.