8000 path_selector remove h5 tag by genericdata · Pull Request #4433 · OSC/ondemand · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

path_selector remove h5 tag #4433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2025
Merged

path_selector remove h5 tag #4433

merged 1 commit into from
Jun 23, 2025

Conversation

genericdata
Copy link
Contributor

Resolves #4432

@johrstrom
Copy link
Contributor

Oh I thought the tests failed here?

@genericdata
Copy link
Contributor Author

It did before. I reverted and the tests passed.

The failure seemed odd and not related to this h5 to div change. Random?

  1. Nginx stage missing users does not crash login when pre hook is misconfigured
    Failure/Error: expect(browser.title).to eq('Dashboard - Open OnDemand')

    expected: "Dashboard - Open OnDemand"
    got: "Log in to dex"`

@johrstrom
Copy link
Contributor

The failure seemed odd and not related to this h5 to div change. Random?

Yea the e2e tests can flake a bit.

Thanks!

@johrstrom johrstrom merged commit b262569 into OSC:master Jun 23, 2025
19 checks passed
@genericdata genericdata deleted the path_selector_h5 branch June 23, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component/dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

path_selector shoudn't have h5 tag
3 participants
@genericdata @johrstrom @osc-bot
0