8000 update from data-toggle to data-bs-toggle by johrstrom · Pull Request #4115 · OSC/ondemand · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

update from data-toggle to data-bs-toggle #4115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2025
Merged

update from data-toggle to data-bs-toggle #4115

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/dashboard/app/helpers/batch_connect/sessions_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ def connection_tabs(id, tabs)
content_tag(:ul, class: "nav nav-tabs") do
tabs.map { |t| t[:title] }.map.with_index do |title, idx|
content_tag(:li, class: "nav-item #{"active" if idx.zero?}") do
link_to title, "#c_#{id}_#{idx}", data: { toggle: "tab" }, aria: { selected: (true if idx.zero?) }, class: "nav-link #{"active" if idx.zero?}"
link_to title, "#c_#{id}_#{idx}", data: { 'bs-toggle': "tab" }, aria: { selected: (true if idx.zero?) }, class: "nav-link #{"active" if idx.zero?}"
end
end.join("\n").html_safe
end
Expand Down
4 changes: 2 additions & 2 deletions apps/dashboard/app/views/ba 8000 tch_connect/settings/_action_buttons.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
class: %w[btn px-1 py-0 btn-outline-dark edit-saved-settings-button full-page-spinner],
title: title,
'aria-label': title,
data: { toggle: "tooltip", placement: "left" }
data: { 'bs-toggle': "tooltip", 'bs-placement': "left" }
) do
fa_icon('pen', classes: nil)
end
Expand All @@ -24,7 +24,7 @@
form_class: %w[d-inline],
title: title,
'aria-label': title,
data: { toggle: "tooltip", placement: "left" },
data: { 'bs-toggle': "tooltip", 'bs-placement': "left" },
params: params
) do
fa_icon('play', classes: nil)
Expand Down
2 changes: 1 addition & 1 deletion apps/dashboard/app/views/batch_connect/settings/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ locals: {
class: %w[btn btn-danger full-page-spinner],
title: title,
'aria-label': title,
data: { confirm: t('dashboard.bc_saved_settings.delete_confirm'), toggle: "tooltip", placement: "left"}
data: { confirm: t('dashboard.bc_saved_settings.delete_confirm'), 'bs-toggle': "tooltip", 'bs-placement': "left"}
) do
"#{fa_icon('times-circle', classes: nil)} <span aria-hidden='true'>#{t('dashboard.delete')}</span>".html_safe
end
Expand Down
0