10000 fix CI by johrstrom · Pull Request #4225 · OSC/ondemand · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix CI #4225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Mar 21, 2025
Merged

fix CI #4225

merged 24 commits into from
Mar 21, 2025

Conversation

johrstrom
Copy link
Contributor

This is a simple change that is needed, but really I just want to test the CI and see what in the wild world of sports is happening with it.

@johrstrom johrstrom marked this pull request as ready for review March 13, 2025 16:02
@johrstrom
Copy link
Contributor Author

This is ready for review, not really sure what's up with Github's CI but it seems like the test code is running much much faster than it should be. I can't reproduce locally so it's got to be something on the github side that's changed, like much faster cpus or some other caching lookahead execution magic or what I can't really say.

Not the cleanest solution to add sleeps all over the place, but what else can be done?

@johrstrom johrstrom changed the title add a note about the demo container to the readme fix CI Mar 14, 2025
@johrstrom
Copy link
Contributor Author

I don't like any of this, but what else can I do? At the time of writing this is 1 of 18 pull requests, blocking all 17. The best I can do is make a ticket for future work to really sort through why this is the case, but at the moment I kinda just need to move forward.

@johrstrom johrstrom mentioned this pull request Mar 21, 2025
Open
@johrstrom johrstrom merged commit fe8e5e1 into master Mar 21, 2025
22 checks passed
@johrstrom johrstrom deleted the test-debug branch March 21, 2025 18:16
johrstrom added a commit that referenced this pull request Mar 25, 2025
@johrstrom
fix CI (#4225)
e9b819f 
Fix the CI by adding sleep calls all over the place. Not the best thing to do, but it is sort of the only thing I can do at this time to keep moving forward.

Note that all these sleeps are only needed for the github CI - running the CI locally 'just works'.
johrstrom added a commit that referenced this pull request Mar 25, 2025
@johrstrom 8512
Merge pull request #4252 from OSC/bp-fix-ci
aba4d2e 
backport fix CI (#4225)
johrstrom added a commit that referenced this pull request Apr 23, 2025
@johrstrom
fix CI (#4225)
6a2450e 
Fix the CI by adding sleep calls all over the place. Not the best thing to do, but it is sort of the only thing I can do at this time to keep moving forward.

Note that all these sleeps are only needed for the github CI - running the CI locally 'just works'.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component/dashboard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johrstrom @osc-bot
0