8000 Export ESRI:54099 WGS_1984_Spilhaus_Ocean_Map_in_Square as PROJ string by rouault · Pull Request #4402 · OSGeo/PROJ · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Export ESRI:54099 WGS_1984_Spilhaus_Ocean_Map_in_Square as PROJ string #4402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 19, 2025

Conversation

rouault
Copy link
Member
@rouault rouault commented Feb 17, 2025

and fix ESRI:54098 mapping to use +proj=spilhaus with +k_0=sqrt(2)

On top of PR #4401

With it:
~/proj/proj/build_cmake$ echo 41.34837298 -117.28057438 | bin/cs2cs EPSG:4326 ESRI:54099
12421874.60 -14140625.11 0.00

Which matches ESRI values of #1851 (comment)

@rouault rouault added this to the 9.6.0 milestone Feb 17, 2025
@rouault rouault mentioned this pull request Feb 17, 2025
Copy link
Contributor
@jjimenezshaw jjimenezshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to make spilhaus projections flexible enough to match ESRI adams ws2.
The only difference is the scale factor affected by sqrt(2).
But I only had the points reported by @mdsumner in the spilhaus issue #1851
If you set spilhaus settings +lat_c, +lon_c, rot and azi all to 0, you should have an Adams_ws2

@rouault
Copy link
Member Author
rouault commented Feb 17, 2025

If you set spilhaus settings +lat_c, +lon_c, rot and azi all to 0, you should have an Adams_ws2

yes I tested that.

We could indeed map ESRI Adams_WS2 as PROJ spillhaus with Scale_factor * sqrt(2) if we get confirmation that there's also a sqrt(2) factor between ESRI:54098 WGS_1984_Adams_Square_II and PROJ's +proj=adams_ws2, hence my request to the community for test points for ESRI:54098 in #1851 (comment) . Or maybe @melitakennedy can provide us with some?

@rouault
Copy link
Member Author
rouault commented Feb 18, 2025

@kbevers I believe this PR / #4401 should be merged before 9.6.0 is cut, even if they are not "perfect", if we don't get inputs before that. For the record, I won't be available next week.

@rouault
Copy link
Member Author
rouault commented Feb 18, 2025

PR updated to be more general and also replicate (almost) ESRI results for ESRI:54098

Thanks to @kgjenkins for https://github.com/kgjenkins/test-coordinates/blob/main/coordinates.csv test points:

$ echo 80 -170 | bin/cs2cs EPSG:4326 ESRI:54098
-9457033.96 13296625.29 0.00

vs ESRI: -9457034.1001 13296625.6969

$ echo 80 -170 | bin/cs2cs EPSG:4326 ESRI:54099
-6624823.23 14253430.38 0.00

vs ESRI: -6624823.16092 14253430.1778

@kbevers
Copy link
Member
kbevers commented Feb 18, 2025

I believe this PR / #4401 should be merged before 9.6.0 is cut, even if they are not "perfect",

I agree, but now that the problem has been dealt with we are in an even better position. I expect to put out the release candidate at the beginning of next week.

@rouault rouault merged commit e9c407a into OSGeo:master Feb 19, 2025
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0