8000 Added proj_geod_direct for PJ trasformation object by vmirgorod · Pull Request #4532 · OSGeo/PROJ · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Added proj_geod_direct for PJ trasformation object #4532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2025
Merged

Added proj_geod_direct for PJ trasformation object #4532

merged 1 commit into from
Jul 2, 2025

Conversation

vmirgorod
Copy link
Contributor
@vmirgorod vmirgorod commented Jun 28, 2025 •
edited
Loading

This PR closes the following issue #4521

Notes:

rouault
rouault reviewed Jun 28, 2025
View reviewed changes
Copy link
Member
@rouault rouault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding a test for the new function in test/unit/gie_self_tests.cpp?

@vmirgorod vmirgorod force-pushed the feature/proj_geod_direct branch from bdf52eb to cb46f34 Compare June 29, 2025 09:20
@vmirgorod
Copy link
Contributor Author

@rouault thank you for your comments, I made necessary changes

@vmirgorod vmirgorod force-pushed the feature/proj_geod_direct branch from cb46f34 to c0dce07 Compare June 29, 2025 09:26
@vmirgorod vmirgorod force-pushed the feature/proj_geod_direct branch from c0dce07 to f6f966c Compare June 29, 2025 12:53
@rouault
Copy link
Member
rouault commented Jul 2, 2025

@busstoptaktik git blame points to you as the one who introduced proj_geod() ;-) Any comment on its inverse companion ?

@busstoptaktik
Copy link
Member

git blame points to you as the one who introduced proj_geod() ;-) Any comment on its inverse companion ?

I probably left it out because I didn't need it back then - or perhaps I was just distracted by life in general :-)

In the meantime, I have implemented a Rust version based on the older and less accurate Vincenty algorithm, which I use occasionally, so nice to see the @cffk version exposed here!

@rouault rouault merged commit 4c2d15e into OSGeo:master Jul 2, 2025
27 checks passed
@rouault rouault added this to the 9.7.0 milestone Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rouault rouault rouault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
9.7.0
Development

Successfully merging this pull request may close these issues.

Missing proj_geod_direct method
3 participants
@vmirgorod @rouault @busstoptaktik
0