Speed-up: pass PJ_COORD by reference for fwd4d and inv4d callbacks #3503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dynamic_cast<> introduced in 718e074 (was also backported in 9.1.1) can be a performance killer for pipelines that are not very computational heavy. Before this fix: ``` $ bin/bench_proj_trans --pipeline "+proj=pipeline +step +proj=unitconvert +xy_in=deg +xy_out=rad +step +proj=merc" 2 49 2 49 -> 222638.981586547 6242595.99979511 Duration: 877 ms Throughput: 5.70 million coordinates/s $ bin/bench_proj_trans --pipeline "+proj=pipeline +step +proj=unitconvert +xy_in=deg +xy_out=rad" 2 49 2 49 -> 0.0349065850398866 0.855211333477221 Duration: 276 ms Throughput: 18.12 million coordinates/s ``` After this fix: ``` $ bin/bench_proj_trans --pipeline "+proj=pipeline +step +proj=unitconvert +xy_in=deg +xy_out=rad +step +proj=merc" 2 49 2 49 -> 222638.981586547 6242595.99979511 Duration: 739 ms Throughput: 6.77 million coordinates/s $ bin/bench_proj_trans --pipeline "+proj=pipeline +step +proj=unitconvert +xy_in=deg +xy_out=rad" 2 49 2 49 -> 0.0349065850398866 0.855211333477221 Duration: 146 ms Throughput: 34.25 million coordinates/s ```
…em directly in pipeline_forward/inverse_4d()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(On top of #3502)
Before this PR:
With this PR: