Reminder Plugin! #18
Reminder Plugin! #18
Conversation
src/sammich/plugins/reminder.py
Outdated
|
|
||
| class ReminderPlugin(MachineBasePlugin): | ||
| def parse_command(self, command_text): | ||
| pattern = re.compile(r"\[(.*?)\]\s+\[(.+?)\]\s+\[(.+?)\]") |
There was a problem hiding this comment.
I suggest moving this to the module level and giving more descriptive name.
There was a problem hiding this comment.
Please check if its okay now !, thanks
|
Sure! lets discuss it tomorrow! |
|
Wouldn't using the Slack-machine function be unnecessary since we still need the Slack API to retrieve Channel Object? The function would simply use the Channel object to return the names and IDs, which only requires two lines of code. Do we really need a separate function for this? |
Not sure what exactly you mean by that but I can surely add more details regarding my suggestion. I recommend using a consistent way while interacting with Slack API. In your case that would be slack-machine client. Only if that doesn't fit your need you should do manually crafted requests to the endpoints. |
No description provided.