8000 Add migration notes for using the 3.0.0 image · Issue #138 · OctoPrint/octoprint-docker · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add migration notes for using the 3.0.0 image #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
morganchristiansson opened this issue Dec 11, 2020 · 6 comments · Fixed by #142
Closed

Add migration notes for using the 3.0.0 image #138

morganchristiansson opened this issue Dec 11, 2020 · 6 comments · Fixed by #142
Assignees
@LongLiveCHIEF
Labels
Documentation

Comments

@morganchristiansson
Copy link
morganchristiansson commented Dec 11, 2020 •
edited
Loading

Describe the bug
After docker-compose pull && docker-compose up -d all my data was gone. Looking inside the container it's created new folder structure under /octoprint/octoprint whereas previously they were in /octoprint

Seems to affect 1.5.0, 1.5.1 and 1.5.2 docker images which all have been pushed in the last 2 days.

To Reproduce

docker-compose exec octoprint1 bash -l
ls -l /octoprint/octoprint

Expected behavior
Files used to live directly under /octoprint

Workaround
I first moved everything to /octoprint/octoprint but plugins stopped working. I guess they should still be in /octoprint/plugins ?

To make things simple I just created symlink using ln -s . octoprint inside /octoprint (outside or inside docker) and everything is back again.

Desktop (please complete the following information):

  • OS: Raspbian
  • Browser n/a
  • Version 1.5.2 / 1.5.x
@cp2004
Copy link
Member
cp2004 commented Dec 12, 2020

I think this is detailed in the release notes V3.0.0

I'll leave someone else to figure out if it is an actual bug, but just wanted to make sure you had read them to see if this explains the behaviour.

@LongLiveCHIEF LongLiveCHIEF self-assigned this Dec 12, 2020
@LongLiveCHIEF
Copy link
Member

Yeah, I was afraid of this, which is why the latest release was a breaking change. I readily admit I should have done a better job of identifying the impact and mitigation steps. I'll get started on that now.

@LongLiveCHIEF
Copy link
Member
LongLiveCHIEF commented Dec 12, 2020 •
edited
Loading

Just FYI moving everything from /octoprint/octoprint was the right instinct, and there was just a missing second step, which was moving the /octoprint/octoprint/plugins/bin and /octoprint/octoprint/plugins/lib directories to /octoprint/plugins.

@LongLiveCHIEF LongLiveCHIEF changed the title [BUG] Data directory changed to /octoprint/octoprint ? Add migration notes for using the 3.0.0 image Dec 12, 2020
@LongLiveCHIEF LongLiveCHIEF mentioned this issue Dec 12, 2020
Merged
@morganchristiansson
Copy link
C0F2 Author

Oh ok. It was unexpected for this to happen when upgrading 1.5.1 to 1.5.2. And further unexpected that existing image tags were updated like this. An upgrade note / breaking changes note in README would've been nice and would also show up on https://hub.docker.com/r/octoprint/octoprint

But fair enough - keep up the good work. 👍

@LongLiveCHIEF
Copy link
Member

An upgrade note / breaking changes note in README would've been nice

There are breaking change notes in both the CHANGELOG and in releases. Even if I put the notes in README, you wouldn't see them before you updated. Whereas with the breaking changes being in the changelog and in releases, gitlab has built-in notification functionality for you by clicking Watch > custom > releases.

In addition to that, I have pinned in both docker channels in discord when there are breaking changes.

Users need to take some responsibility to check for changes before pulling new images, and I'm doing everything I can to push notifications in multiple places and ways.

@LongLiveCHIEF
Copy link
Member

@morganchristiansson I've made a change to the README in PR #142 that contains the following language. Can you read it over and let me know if you think that would have worked for you had it been there beforehand?

The octoprint/octoprint image uses semantic versioning, but the tags for octoprint/octoprint follow the
version of octoprint contained in the image. As a result we recommend you always check the CHANGELOG
or Releases before pulling an image, even if you are pulling the same tag.

You can subscribe to be notified of releases as well, by selecting the Watch button in the upper right corner,
choosing "Custom", and checking "Releases".

In addition, we know that OctoPrint is not the best suited type of application for containerization, but we're
working hard to make it as compatible as possible. Please check out our Roadmap,
or join the discussion in the #dev-docker or #support-docker channels on the official OctoPrint Discord
discord.octoprint.org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LongLiveCHIEF LongLiveCHIEF

Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

V3 image migration OctoPrint/octoprint-docker
3 participants
@morganchristiansson @LongLiveCHIEF @cp2004
0