V3 image migration #142
Merged
V3 image migration #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm also slightly worried about the potential of breaking symlinks for wheel libs, but I haven't found a way to test for that yet. I'd probably need to tweak this script to look for symlinks on the sys.path for wheels and update them to point to PYTHONUSERBASE/lib/. 🤔 |
|
Before I pull this, i want to run the following test just to make sure this doesn't break anything:
|
add instructions for env var add instructions about checking for releases
9f35e56 to
388c175
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of creating a migration strategy guide in the release docs, I went the route of detecting when a v3 container was being started with a v2 file structure, and then auto-migrate the file structures for them during container initialization.
This would potentially be a breaking release, in the event that two octoprint containers are using the same volume and the second container is added while the first (which is a v2 container) is running.
However, I've decided against classifying this as a breaking change (and thereby requiring a v4 release), because the current design of octoprint and octoprint in docker does not really support horizontal scaling due to the requirements to bind a host device.