Ruff #1686
Closed
Ruff #1686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 20, 2025
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to facilitate future contributions, I would like to propose an automated linter. Specifically, ruff is extremely fast and not apologetic about arguably sensible opinions.
Thus far, this PR contains:
pyproject.tomlfile anduv.lockfor (extremely) fast and efficient local dependency and environment management with uv. This is just a suggestion and it's easy to leave this out of the final PR and/or shoot in a separate one. Consideruvto bepoetryon steroids (~10 faster). Advantages of a lock file and a dependency management tool is that it resolves cross-dependencies and yields (much faster) reproducible builds.Of course, specific linter errors can be disabled, I'm happy to integrate feedback. The main point is that enforcing any linter is much, much, much much much better in any FOSS project than not having one.
This draft PR is to a large extent an invitation to dialogue to:
pyproject.toml, towards re-enabling support without Docker.ruff format) for cleaner diffs and more consistently readable code.Enabling 5 will imply a single automated formatting pass across the entire codebase, implying a large diff with no functional changes, after which new diffs (thanks to pre-commit magic) will only include code as formatting will be fully automatic.