8000 Swath wizard by cbielow · Pull Request #4647 · OpenMS/OpenMS · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Swath wizard #4647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Apr 21, 2020
Merged

Swath wizard #4647

merged 17 commits into from
Apr 21, 2020

Conversation

cbielow
Copy link
Contributor
@cbielow cbielow commented Apr 15, 2020

the first of many piece-wise PRs to a new Wizard for Swath data...

fixes some build-system issues for MOC/UI classes along the way

@ghost
Copy link
ghost commented Apr 15, 2020

Congratulations 🎉. DeepCode analyzed your code in 1.154 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard

@timosachsenberg
Copy link
Contributor

screenshots or it didn't happen ;)

timosachsenberg
timosachsenberg reviewed Apr 16, 2020
View reviewed changes
timosachsenberg
timosachsenberg reviewed Apr 16, 2020
View reviewed changes
timosachsenberg
timosachsenberg reviewed Apr 16, 2020
View reviewed changes
timosachsenberg
timosachsenberg requested changes Apr 17, 2020
View reviewed changes
Copy link
Contributor
@timosachsenberg timosachsenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comments

@cbielow
Copy link
Contributor Author
cbielow commented Apr 20, 2020 •
edited
Loading

screenshots or it didn't happen ;)

image

@cbielow
Copy link
Contributor Author
cbielow commented Apr 21, 2020

ready for merge
failing tests are false positives (e.g. https://github.com/OpenMS/OpenMS/pull/4647/files#annotation_173257328)

@timosachsenberg timosachsenberg merged commit 3e7e3f3 into OpenMS:develop Apr 21, 2020
@jpfeuffer
Copy link
Contributor

This might have broken the nightlies on macOS. We need to investigate.

@cbielow cbielow mentioned this pull request May 28, 2020
Merged
@cbielow cbielow mentioned this pull request Jun 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timosachsenberg timosachsenberg timosachsenberg requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cbielow @timosachsenberg @jpfeuffer
0