8000 overwrite design file names with input file names (as we know those e… by timosachsenberg · Pull Request #5557 · OpenMS/OpenMS · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

overwrite design file names with input file names (as we know those e… #5557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 23, 2021
Merged

overwrite design file names with input file names (as we know those e… #5557

merged 2 commits into from
Sep 23, 2021

Conversation

timosachsenberg
Copy link
Contributor

…xist on the filesystem)

Description

design filenames might be URLs etc. input files are known to exist (e.g., get checked by TOPPBase).
So we overwrite differing design filenames with the input filenames based on their basename.

Checklist:

  • Make sure that you are listed in the AUTHORS file
  • Add relevant changes and new features to the CHANGELOG file
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes
  • Updated or added python bindings for changed or new classes. (Tick if no updates were necessary.)

How can I get additional information on failed tests during CI:

If your PR is failing you can check out

Note:

  • Once you opened a PR try to minimize the number of pushes to it as every push will trigger CI (automated builds and test) and is rather heavy on our infrastructure (e.g., if several pushes per day are performed).

@timosachsenberg timosachsenberg linked an issue Sep 23, 2021 that may be closed by this pull request
PLFQ does not work with URLs in design #5556
Closed
@timosachsenberg timosachsenberg mentioned this pull request Sep 23, 2021
Closed
@jpfeuffer jpfeuffer merged commit 31fe8b8 into OpenMS:develop Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpfeuffer jpfeuffer jpfeuffer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PLFQ does not work with URLs in design
2 participants
@timosachsenberg @jpfeuffer
0