8000 TOPPView: fix Ctrl-w and Ctrl-a not working and support recent dir for File->Open by cbielow · Pull Request #6703 · OpenMS/OpenMS · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

TOPPView: fix Ctrl-w and Ctrl-a not working and support recent dir for File->Open #6703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 17, 2023
Merged

TOPPView: fix Ctrl-w and Ctrl-a not working and support recent dir for File->Open #6703

merged 6 commits into from
Feb 17, 2023

Conversation

cbielow
Copy link
Contributor
@cbielow cbielow commented Feb 16, 2023 •
edited
Loading

Description

fixes #6670.

fixes #6642:

  • this used to work previously, but (recently?) Qt seems to pass a 0 by default as first argument, which disabled the automatic switch to the current directory of the shown layer. This is fixed now.

Checklist

  • Make sure that you are listed in the AUTHORS file
  • Add relevant changes and new features to the CHANGELOG file
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes
  • Updated or added python bindings for changed or new classes (Tick if no updates were necessary.)

How can I get additional information on failed tests during CI

Click to expand If your PR is failing you can check out
  • The details of the action statuses at the end of the PR or the "Checks" tab.
  • http://cdash.openms.de/index.php?project=OpenMS and look for your PR. Use the "Show filters" capability on the top right to search for your PR number.
    If you click in the column that lists the failed tests you will get detailed error messages.

Advanced commands (admins / reviewer only)

Click to expand
  • /reformat (experimental) applies the clang-format style changes as additional commit. Note: your branch must have a different name (e.g., yourrepo:feature/XYZ) than the receiving branch (e.g., OpenMS:develop). Otherwise, reformat fails to push.
  • setting the label "NoJenkins" will skip tests for this PR on jenkins (saves resources e.g., on edits that do not affect tests)
  • commenting with rebuild jenkins will retrigger Jenkins-based CI builds

⚠️ Note: Once you opened a PR try to minimize the number of pushes to it as every push will trigger CI (automated builds and test) and is rather heavy on our infrastructure (e.g., if several pushes per day are performed).

cbielow added a commit to cbielow/OpenMS-docs that referenced this pull request Feb 16, 2023
@cbielow
fix keyboard shortcut (amends
1d857e3 
OpenMS/OpenMS#6703)
@cbielow cbielow mentioned this pull request Feb 16, 2023
Merged
5 tasks
cbielow added a commit to OpenMS/OpenMS-docs that referenced this pull request Feb 17, 2023
@cbielow
fix keyboard shortcut (#191)
c2af13b 
fix keyboard shortcut (amends
OpenMS/OpenMS#6703)
@cbielow cbielow mentioned this pull request Feb 17, 2023
Closed
@cbielow cbielow changed the title TOPPView: fix Ctrl-w and Ctrl-a not working TOPPView: fix Ctrl-w and Ctrl-a not working and support recent dir for File->Open Feb 17, 2023
@cbielow
Copy link
Contributor Author
cbielow commented Feb 17, 2023

CI passes (shows failed because of CDash website down).
Will merge.

@cbielow cbielow merged commit 2fec799 into OpenMS:develop Feb 17, 2023
cbielow added a commit to OpenMS/OpenMS-docs that referenced this pull request Sep 15, 2023
@cbielow
Docs toppas (#210)
de5e6d1 
* fix keyboard shortcut (amends
OpenMS/OpenMS#6703)

* linking to TOPPAS docs;
* fixing some minor glossary quirks
* remove MCP links... they keep being trouble...
* use seqan.de due to certificate issues with openms.de
matteopilz pushed a commit to OpenMS/OpenMS-docs that referenced this pull request May 7, 2024
@cbielow
Fix link in dark mode (#230)
0503d8e 
* fix keyboard shortcut (amends
OpenMS/OpenMS#6703)

* fix link in dark mode

* another broken link
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TOPPView on windows : some hot key mappings may be incorrect. Add support for file dialog in TOPPView to default to the last opened directory
1 participant
@cbielow
0